GNOME Bugzilla – Bug 710918
Make the button pad more spacious
Last modified: 2014-12-23 04:17:50 UTC
The current style of the calculator doesn't quite fit GNOME 3's new trend for application design. Although the calculator features an AppMenu already and GtkHeaderBar is apparently coming (see bug 705909), the buttons remain tiny and tight with not much room to breathe. Simply making the buttons bigger (more padding) and adding a bit of space between them would make wonders. As a bonus, this might help with bug 614412 as well.
Created attachment 278248 [details] [review] adds paddings and color to buttons
Review of attachment 278248 [details] [review]: First of all, the patch is not a valid format patch. Please use "git format-patch" or equivalent commands to generate the patch. 2. this also includes history view code. Please split the changes. 3. there are 55 trailing whitespace errors. 4. the method used for coloring buttons, is it really the best way to do so? 5. the colors takes effect only when the window is inactive, and not while it's active. 6. the colors doesn't work in GTK dark color mode. ::: src/math-buttons.vala @@ +422,3 @@ } } + Gdk.RGBA color = Gdk.RGBA(); Missing space before function call parenthesis. Which is there in almost the entire patch. @@ +428,3 @@ button.clicked.connect (() => { equation.insert_subtract (); }); + color.parse("silver"); + button.override_background_color(Gtk.StateFlags.NORMAL,color); Missing space between parameters of call. Which is there in almost the entire patch. i.e. func<space>(a,<space>b); instead of func(a,b); @@ +717,2 @@ _programming_base = value; + notify_property ("programming-base"); Why is there an explicit invocation of notify for programming-base?
*** This bug has been marked as a duplicate of bug 614412 ***