Bug 710884 – Gedit Open Dialog Bookmarks: crash when reordering a file to itself

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 710884 - Gedit Open Dialog Bookmarks: crash when reordering a file to itself


Summary:	Gedit Open Dialog Bookmarks: crash when reordering a file to itself


Status:	RESOLVED FIXED

Product:	gtk+
Classification:	Platform
Component:	Widget: GtkFileChooser
Version:	3.8.x
Hardware:	Other Linux

Importance:	High critical
Target Milestone:	---
Assigned To:	gtk-bugs
QA Contact:	Federico Mena Quintero

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2013-10-25 16:03 UTC by mar77i
Modified:	2014-08-03 10:05 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description mar77i 2013-10-25 16:03:47 UTC

IMO, it's not meant to be the way it is, but it's possible to draw files into the bookmarks list. It is then not possible to remove that file (the bookmark will not want to be marked somehow), and the entry above will be removed instead.

When you then move the file entry on top or beneath itself, gedit will crash with the following Terminal output:

Gtk:ERROR:/build/buildd/gtk+3.0-3.8.4/./gtk/gtkfilechooserdefault.c:3104:shortcuts_reorder: code should not be reached
Aborted (Core dumped)

Please get in touch if you need the coredump, though I guess it should be pretty straightforward to reproduce.

Thing is, I'm not sure if files are even meant to be bookmarks in that context, I trust the Gnome team can make the decisions so they will fit for everyone...

Comment 1 André Klapper 2013-10-25 17:28:33 UTC

Confirming, but looks like gtk territory.

Gtk:ERROR:gtkfilechooserdefault.c:3104:shortcuts_reorder: code should not be reached

Program received signal SIGABRT, Aborted.
0xb7fff424 in __kernel_vsyscall ()
Missing separate debuginfos, use: debuginfo-install python3-gobject-3.8.3-1.fc19.i686 python3-libs-3.3.2-6.fc19.i686
(gdb) thread apply all bt

+ Trace 232668

Thread 1 (Thread 0xb7fbb880 (LWP 16448))

#0 __kernel_vsyscall
#1 __GI_raise
at ../nptl/sysdeps/unix/sysv/linux/raise.c line 56
#2 __GI_abort
at abort.c line 90
#3 g_assertion_message
#4 shortcuts_reorder
at gtkfilechooserdefault.c line 3104
#5 shortcuts_drag_data_received_cb
at gtkfilechooserdefault.c line 3189
#6 _gtk_marshal_VOID__OBJECT_INT_INT_BOXED_UINT_UINT
at gtkmarshalers.c line 5276
#7 g_closure_invoke
at gclosure.c line 777
#8 signal_emit_unlocked_R
at gsignal.c line 3584
#9 g_signal_emit_valist
at gsignal.c line 3328
#10 g_signal_emit_by_name
at gsignal.c line 3424
#11 gtk_drag_selection_received
at gtkdnd.c line 1922
#12 _gtk_marshal_VOID__BOXED_UINT
at gtkmarshalers.c line 3268
#13 g_closure_invoke
at gclosure.c line 777
#14 signal_emit_unlocked_R
at gsignal.c line 3584
#15 g_signal_emit_valist
at gsignal.c line 3328
#16 g_signal_emit_by_name
at gsignal.c line 3424
#17 gtk_selection_retrieval_report
at gtkselection.c line 2983
#18 gtk_selection_convert
at gtkselection.c line 1114
#19 gtk_drag_get_data
at gtkdnd.c line 1135
#20 gtk_drag_dest_drop
at gtkdnd.c line 2423
#21 gtk_drag_find_widget
at gtkdnd.c line 2004
#22 _gtk_drag_dest_handle_event
at gtkdnd.c line 1758
#23 gtk_main_do_event
at gtkmain.c line 1749
#24 _gdk_event_emit
at gdkevents.c line 69
#25 gdk_event_source_dispatch
at gdkeventsource.c line 364
#26 g_main_dispatch
at gmain.c line 3054
#27 g_main_context_dispatch
at gmain.c line 3630
#28 g_main_context_iterate
at gmain.c line 3701
#29 g_main_context_iteration
at gmain.c line 3762
#30 g_application_run
at gapplication.c line 1623
#31 main
at gedit.c line 68

Comment 2 Matthias Clasen 2014-08-03 10:05:29 UTC

I'm afraid I can't reproduce this here, thus assuming it was fixed. If you can still reproduce with 3.12 or 3.13, please reopen.