After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710566 - Repeated code in src/Makefile.am
Repeated code in src/Makefile.am
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-20 20:05 UTC by Magdalen Berns (irc magpie)
Modified: 2013-10-30 14:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
define dbus_idle_build_sources only once (786 bytes, patch)
2013-10-20 20:09 UTC, Magdalen Berns (irc magpie) 		committed Details | Review

Description Magdalen Berns (irc magpie) 2013-10-20 20:05:40 UTC 
dbus_idle_built_sources is defined twice where it should only be defined once.
Comment 1 Magdalen Berns (irc magpie) 2013-10-20 20:09:12 UTC 
Created attachment 257780 [details] [review]
define dbus_idle_build_sources only once
Comment 2 drago01 2013-10-28 16:09:49 UTC 
Review of attachment 257780 [details] [review]:

This is only defined one in line that you remove.
Comment 3 Magdalen Berns (irc magpie) 2013-10-28 16:32:19 UTC 
It's defined twice: 

Once on line 329 and again on line 398
Comment 4 drago01 2013-10-28 20:41:12 UTC 
(In reply to comment #3)
> It's defined twice: 
> 
> Once on line 329 and again on line 398

Huh?

https://git.gnome.org/browse/mutter/tree/src/Makefile.am#n329

And there is no line 398 ...
Comment 5 drago01 2013-10-28 20:54:05 UTC 
Review of attachment 257780 [details] [review]:

OK this is about the wayland branch so ok.
Comment 6 David King 2013-10-29 13:11:32 UTC 
Comment on attachment 257780 [details] [review]
define dbus_idle_build_sources only once

Pushed to the wayland branch as 1bd3a162f8b2e66969342353fc1ff5023a7cc83e.
Comment 7 Magdalen Berns (irc magpie) 2013-10-30 14:56:57 UTC 
Thanks