GNOME Bugzilla – Bug 710492
JPEG loader does not respect EXIF Orientation tag
Last modified: 2018-05-22 12:06:43 UTC
I have several photos that were taken with a phone camera. The thumbnail view displays everything oriented properly, but the full size view shows many of the pictures sideways or even upside down. I can provide a test photo if need be, but I imagine you can generate your own, and it won't waste space on your bug tracker.
It would still be nice to have a test photo. You can email it to rishi.is@lostca.se if it is too big to be attached here.
Turns out I'll have to e-mail it; it exceeds the bug tracker's maximum attachment size. I'll do so shortly.
After a brief discussion in #gegl, we decided that this needs to be fixed in the loaders used by the gegl:load operation.
There are sample images in bug 734844
Created attachment 294595 [details] [review] jpg-load: Add orientation property for reading Exif tag
I cannot play picture file with format JPEG and BITMAP.
Review of attachment 294595 [details] [review]: What are the meaning of the 9 different Exif values? I think we should expose a standardized property (type) for the orientation, so that all loaders (png, gif, jpeg, $foo) will have the same "interface". When changing the backing storage for a property value (o->orientation = something), pretty sure you must call g_object_notify() to signal the change. Also, the propety should be read-only, because it cannot be set from outside.
We could have a GeglOrientation enum, similar and maybe even compatible value-for-value with the Exif ones. https://github.com/GNOME/gexiv2/blob/master/gexiv2/gexiv2-metadata.h#L45 http://jpegclub.org/exif_orientation.html
(In reply to comment #7) > When changing the backing storage for a property value (o->orientation = > something), pretty sure you must call g_object_notify() to signal the change. Done. > Also, the propety should be read-only, because it cannot be set from outside. That will need some addition to the chant system because currently all properties are READWRITE. What about a read_only() modifier similar to description()? pippin said that he preferred a modifier instead of adding an extra flags parameter to property_int, etc..
Created attachment 295164 [details] [review] jpg-load: Add orientation property for reading Exif tag
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gegl/issues/16.