After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710488 - Incorrect scrollbar position after restricted scrolling
Incorrect scrollbar position after restricted scrolling
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.34.x
Other Linux
: Normal normal
: vte-0-36
Assigned To: VTE Maintainers
VTE Maintainers
[fixed-0-36][needed-next][commit:bba3...
: 537801 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-19 01:07 UTC by Egmont Koblinger
Modified: 2014-04-27 07:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (431 bytes, patch)
2013-10-19 01:37 UTC, Egmont Koblinger 		committed Details | Review

Description Egmont Koblinger 2013-10-19 01:07:53 UTC 
Produce at least a screenful of text so that the scrollbar is active. Then enable restricting scrolling, with the upper bound being the topmost row, e.g.
echo -e '\e[1;15r'

Produce more output so that the cursor hits the boundary at the 15th row and the content starts scrolling. The scrollbar starts wandering upwards, though it should stay at the bottom.

When you try to scroll by Shift+PageUp or by dragging the scrollbar, suddenly everything jumps back to normal.
Comment 1 Egmont Koblinger 2013-10-19 01:37:56 UTC 
Created attachment 257683 [details] [review]
Fix

The out-of-sync behavior between the scrollbar and the actual visual position is caused by directly altering scroll_delta, rather than via vte_terminal_queue_adjustment_value_changed(). This omits calling the desired gtk update hooks (via the update timeout).

I think the correct behavior is not to update the scroll_delta here. If the scrollbar is snapped to the bottom, it will remain snapped there. If it's anywhere else, the desired behavior IMO is to keep the currently visible part on the screen, just as in the non-restricted scrolling case.
Comment 2 Christian Persch 2013-11-18 18:54:29 UTC 
Fixed on vte-0-36.
Comment 3 Christian Persch 2014-04-27 07:45:47 UTC 
*** Bug 537801 has been marked as a duplicate of this bug. ***