GNOME Bugzilla – Bug 710400
gone overboard with low contrast
Last modified: 2013-12-20 11:17:42 UTC
I think we went too far with the low contrast. Polari looks washed out most of the time. We should possibly: - use a tad darker grey for inactive channels (maybe #555753) - use a timer for setting (I thought it wasn't necessary initially, but on a second thought it does seem a bit weird to actively participate in a conversation in .. an inactive room). - bring a bit of color to associate lines with specific users. Rather than using plain color coding of nicknames, Jon suggested using something similar to how google creates colored squares with people's initials in gmail. See a relevant discussion in bug #655116
the timer above refers to inactive channels, not sure what happened to the sentence there ;)
(In reply to comment #0) > - use a tad darker grey for inactive channels (maybe #555753) So far all custom colors I've been using are modified colors from the default theme (for instance in this case: alpha(@theme_text_color, 0.4)). The idea is that like that there's a better chance that my customizations won't break completely on Adwaita changes. Is this a good idea? Can you suggest a color in that case? > - use a timer for setting (I thought it wasn't necessary initially, but on a > second thought it does seem a bit weird to actively participate in a > conversation in .. an inactive room). So before you made me drop this, my though was to use an accumulative timer, e.g. use a small timeout initially, but increase it with every message - the idea is to mark a channel with a single "hello, anyone here?" message as inactive fairly quickly, while keeping a channel with a vivid discussion active for a longer time. Does that make sense? > - bring a bit of color to associate lines with specific users. Unrelated IMHO, can you add this as comment to bug 710208?
(In reply to comment #2) > So far all custom colors I've been using are modified colors from the default > theme (for instance in this case: alpha(@theme_text_color, 0.4)). The idea is > that like that there's a better chance that my customizations won't break > completely on Adwaita changes. Is this a good idea? Can you suggest a color in > that case? This is excellent practice, I think we went overboard with named colors in Adwaita actually. mixing colors and alpha blending makes much more sense. I'll actually try providing a patch. > So before you made me drop this, my though was to use an accumulative timer, > e.g. use a small timeout initially, but increase it with every message - the > idea is to mark a channel with a single "hello, anyone here?" message as > inactive fairly quickly, while keeping a channel with a vivid discussion active > for a longer time. Does that make sense? I think that would work.
(In reply to comment #3) > This is excellent practice Good to hear - it has the obvious drawback of breaking with other GTK+ themes that don't define those color names, but meh ... > I'll actually try providing a patch. That's good to hear as well!
Created attachment 257599 [details] [review] theme: style inactive channels - make inactive channels look less disabled/insensitive - use color mixing rather than alpha blending
Review of attachment 257599 [details] [review]: Thanks!
Comment on attachment 257599 [details] [review] theme: style inactive channels Attachment 257599 [details] pushed as 9085fc3 - theme: style inactive channels
I guess is fixed, isn't it?