GNOME Bugzilla – Bug 710295
delete action too close to pause
Last modified: 2016-03-31 13:22:07 UTC
(from Montreal summit session) It is uncomfortable to have a destructive action like 'Delete' sit so close to the harmless 'Pause' action. It would also be nice to use a symbolic pause icon instead of the label.
(In reply to comment #0) > (from Montreal summit session) > > It is uncomfortable to have a destructive action like 'Delete' sit so close to > the harmless 'Pause' action. Sure, makes sense. > It would also be nice to use a symbolic pause icon instead of the label. Wha? We recently moved all these buttons from icons to labels based on the new GNOME3 trend.
(In reply to comment #1) > (In reply to comment #0) > > (from Montreal summit session) > > > > It is uncomfortable to have a destructive action like 'Delete' sit so close to > > the harmless 'Pause' action. > > Sure, makes sense. But where shall I put it? In the middle? Would look really weird. I would have the same issue if I put it on the right side next to properties button.
Just some raw ideas: * Clocks does have the delete button on the right. Can we think of another way to access the properties so that the delete button can go there? In theory this bottom-bar is for multi-VM-actions. Showing the properties of one isn't this kind of action. * I think I have seen it colored red in some gnome application. Don't remember where.
(In reply to Lasse Schuirmann from comment #3) > Just some raw ideas: > > * Clocks does have the delete button on the right. Can we think of another > way to access the properties so that the delete button can go there? In > theory this bottom-bar is for multi-VM-actions. Showing the properties of > one isn't this kind of action. Hmm.. yeah, we now have context menu to go to properties too so maybe we could simply replace properties button with that. Jimmac? > * I think I have seen it colored red in some gnome application. Don't > remember where. Another good idea.
Created attachment 298543 [details] [review] selectionbar: Move delete button to the right This moves the delete button to the right of the selectionbar.
Created attachment 298544 [details] [review] selectionbar: Set remove as destructive This adds the destructive-action style class to remove button.
Created attachment 298545 [details] [review] selectionbar: Remove properties button This removes the properties button.
Review of attachment 298543 [details] [review]: Commit message isn't really good because you don't move the button but you switch those two. IMO it would make more sense to first remove the properties button, then move the delete one to the right and then mark as destructive. Looks good otherwise.
Review of attachment 298544 [details] [review]: ::: src/selectionbar.vala @@ +19,2 @@ construct { + remove_btn.get_style_context ().add_class ("destructive-action"); can't this be done in the XML definition? Seperating UI and code as much as possible.
Rest looks good for me, I'll do a more thorough review in the next patch iteration.
Created attachment 298552 [details] [review] selectionbar: Remove properties button This removes the properties button from the selectionbar.
Created attachment 298553 [details] [review] selectionbar: Move delete button to the end This moves the delete button to the end of the selectionbar.
Created attachment 298554 [details] [review] selectionbar: Set delete as destructive This adds the destructive-action style class to delete button.
Review of attachment 298552 [details] [review]: ack
Review of attachment 298553 [details] [review]: ack
Review of attachment 298554 [details] [review]: ack, thats better :)
pushing trivial commits without zeeshan's review.
Sorry, it's UI freeze, so I've reverted them at an instant. Zeeshan, sorry for this mess :(
(In reply to Lasse Schuirmann from comment #19) > Sorry, it's UI freeze, so I've reverted them at an instant. Zeeshan, sorry > for this mess :( No worries. Feel free to create a gnome-3-17 branch already and push these there.
(In reply to Zeeshan Ali (Khattak) from comment #20) > (In reply to Lasse Schuirmann from comment #19) > > Sorry, it's UI freeze, so I've reverted them at an instant. Zeeshan, sorry > > for this mess :( > > No worries. Feel free to create a gnome-3-17 branch already and push these > there. Done.
Comment on attachment 298552 [details] [review] selectionbar: Remove properties button We totally forgot about these patches and I only remembered this bug after I already re-did this patch from scratch. No biggie, its a small patch. I'm obsoleting this one cause mine provides better commit log. :P
Attachment 298553 [details] pushed as 627c43f - selectionbar: Move delete button to the end Attachment 298554 [details] pushed as 840e8f2 - selectionbar: Set delete as destructive Also pushed: commit: 534d3f010115b1bdd81b63df0a289c896508fe58 selectionbar: Drop Properties button Not only this is available in both context menu and hamburger (display) menu, this is the only single item action in the selection mode and selection mode is meant for multiple item actions.