After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710254 - gthemedicon: Fallback to non-symbolic icons
gthemedicon: Fallback to non-symbolic icons
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.38.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-10-16 09:32 UTC by Olivier Brunel (jjacky)
Modified: 2013-10-24 12:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gthemedicon: Fallback to non-symbolic icons (1.38 KB, patch)
2013-10-16 09:32 UTC, Olivier Brunel (jjacky) 		committed Details | Review

Description Olivier Brunel (jjacky) 2013-10-16 09:32:26 UTC 
Created attachment 257407 [details] [review]
gthemedicon: Fallback to non-symbolic icons

When doing fallback for symbolic icons, first shorten the name at dashes
while preserving the -symbolic suffix, then try stripping the suffix.

Based on similar patch for GTK, see https://bugzilla.gnome.org/show_bug.cgi?id=708163
Comment 1 Matthias Clasen 2013-10-16 18:06:56 UTC 
Review of attachment 257407 [details] [review]:

yeah, we should keep that in sync. Sucks to have it in two places, of course
Comment 2 Matthias Clasen 2013-10-24 12:10:03 UTC 
Attachment 257407 [details] pushed as 0a7d108 - gthemedicon: Fallback to non-symbolic icons