GNOME Bugzilla – Bug 710178
Skip whitespace between oFono vCards
Last modified: 2013-10-22 06:50:49 UTC
The vCards we get from oFono are typically separated by a blank line, and the code currently doesn’t strip that line, resulting in lots of these warnings: libebook-contacts-WARNING **: vcard began without a BEGIN:VCARD libebook then skips the blank line and correctly parses the vCard. Patch coming to skip the line ourselves and eliminate the warnings.
Created attachment 257344 [details] [review] ofono: Skip whitespace between vCards when splitting them up This eliminates the following libebook warning which we were triggering. libebook itself skips the whitespace, so this introduces no functional changes. libebook-contacts-WARNING **: vcard began without a BEGIN:VCARD
Comment on attachment 257344 [details] [review] ofono: Skip whitespace between vCards when splitting them up Reviewed on IRC by Xavier. commit f9907524e16a121b7b88ca369b34a7719c510072 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Tue Oct 15 12:27:06 2013 +0100 ofono: Skip whitespace between vCards when splitting them up This eliminates the following libebook warning which we were triggering. libebook itself skips the whitespace, so this introduces no functional changes. libebook-contacts-WARNING **: vcard began without a BEGIN:VCARD https://bugzilla.gnome.org/show_bug.cgi?id=710178 NEWS | 1 + backends/ofono/ofono-persona-store.vala | 4 ++++ 2 files changed, 5 insertions(+)