After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710019 - JS ERROR: TypeError: this._ensureActiveConnectionProps is not a function
JS ERROR: TypeError: this._ensureActiveConnectionProps is not a function
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-12 22:06 UTC by Michael Catanzaro
Modified: 2013-10-13 00:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
NetworkMenu: fix regression for VPN connections (1.03 KB, patch)
2013-10-13 00:11 UTC, Giovanni Campagna
committed Details | Review

Description Michael Catanzaro 2013-10-12 22:06:31 UTC
When turning on a VPN connection in gnome-control-center network panel:

(gnome-shell:5144): Gjs-WARNING **: JS ERROR: TypeError: this._ensureActiveConnectionProps is not a function
NMApplet<._syncVPNConnections/<@/home/mcatanzaro/jhbuild/install/share/gnome-shell/js/ui/status/network.js:1529
NMApplet<._syncVPNConnections@/home/mcatanzaro/jhbuild/install/share/gnome-shell/js/ui/status/network.js:1528
wrapper@/home/mcatanzaro/jhbuild/install/share/gjs-1.0/lang.js:213

(Note that ensureActiveConnectionProps is a free function.)
Comment 1 Giovanni Campagna 2013-10-13 00:11:14 UTC
Created attachment 257135 [details] [review]
NetworkMenu: fix regression for VPN connections

Fix regression from e898e2991087e7ccb17bc17f2eedd99a1f41152a,
the code was moved from a method to a global function, but one
call site was not updated.
Comment 2 Florian Müllner 2013-10-13 00:14:01 UTC
Review of attachment 257135 [details] [review]:

Yes
Comment 3 Giovanni Campagna 2013-10-13 00:14:53 UTC
Attachment 257135 [details] pushed as d084770 - NetworkMenu: fix regression for VPN connections