After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710018 - GObject introspection improvements
GObject introspection improvements
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal enhancement
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-12 21:59 UTC by Sebastian Pölsterl
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes GIR warnings (7.95 KB, patch)
2013-10-12 21:59 UTC, Sebastian Pölsterl 		none Details | Review
Fixes GIR warnings (8.51 KB, patch)
2013-10-12 22:17 UTC, Sebastian Pölsterl 		committed Details | Review

Description Sebastian Pölsterl 2013-10-12 21:59:10 UTC 
Created attachment 257130 [details] [review]
Fixes GIR warnings

The attached patch fixes several issues revealed by g-ir-scanner and g-ir-compiler by updating API comments.
Comment 1 Sebastian Pölsterl 2013-10-12 22:17:55 UTC 
Created attachment 257131 [details] [review]
Fixes GIR warnings

Added one more annotation.
Comment 2 Sebastian Dröge (slomo) 2013-10-14 18:47:04 UTC 
Review of attachment 257131 [details] [review]:

Looks good except

::: gst/rtsp-server/rtsp-context.c
@@ +31,2 @@
 /**
+ * gst_rtsp_context_get_current: (skip)

Why skip this? This seems useful for bindings too
Comment 3 Sebastian Pölsterl 2013-10-14 20:17:46 UTC 
It returns GstRTSPContext, which is a simple struct and not a boxed type, therefore it usually cannot get bind.
Comment 4 Sebastian Dröge (slomo) 2013-10-14 20:20:26 UTC 
That should probably be fixed then :)
Comment 5 Wim Taymans 2013-11-12 10:18:34 UTC 
commit e756324490490761e4027639caaa6589ab335b1b
Author: Sebastian Pölsterl <sebp@k-d-w.org>
Date:   Sat Oct 12 23:56:00 2013 +0200

    Fixed several GIR warnings
Comment 6 Wim Taymans 2013-11-12 10:25:53 UTC 
commit d443f8546b075f64774678ecb860b3c8eb3b5079
Author: Wim Taymans <wim.taymans@gmail.com>
Date:   Tue Nov 12 11:21:55 2013 +0100

    context: defing a GType for the context
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=710018