GNOME Bugzilla – Bug 709995
Obsolete makefile rules
Last modified: 2013-10-17 18:13:04 UTC
Created attachment 257110 [details] [review] Fixed makefile syntax; [make test still fails due to other reasons] If I run 'make test' in my tree, I get the following: parallels@ubuntu:~/hackaton/glib$ make test make[1]: Entering directory `/home/parallels/hackaton/glib/m4macros' make[1]: Leaving directory `/home/parallels/hackaton/glib/m4macros' make[1]: Entering directory `/home/parallels/hackaton/glib/glib' make[2]: Entering directory `/home/parallels/hackaton/glib/glib/libcharset' make[2]: Leaving directory `/home/parallels/hackaton/glib/glib/libcharset' make[2]: Entering directory `/home/parallels/hackaton/glib/glib/pcre' make[2]: Leaving directory `/home/parallels/hackaton/glib/glib/pcre' make[2]: Entering directory `/home/parallels/hackaton/glib/glib/update-pcre' make[2]: Leaving directory `/home/parallels/hackaton/glib/glib/update-pcre' make[2]: Entering directory `/home/parallels/hackaton/glib/glib/tests' make[2]: *** No rule to make target `test'. Stop. make[2]: Leaving directory `/home/parallels/hackaton/glib/glib/tests' /bin/bash: line 2: exit: test-nonrecursive: numeric argument required make[1]: *** [test] Error 255 make[1]: Leaving directory `/home/parallels/hackaton/glib/glib' /bin/bash: line 2: exit: test-nonrecursive: numeric argument required make: *** [test] Error 255
It seems that this rule (and some other) are just obsolete, so there is no reason to fix them.
Created attachment 257442 [details] [review] Remove obsolete makefile rules
Review of attachment 257442 [details] [review]: This looks correct to me.
https://git.gnome.org/browse/glib/commit/?id=aaddd823bcce4c5f751cb694c7c7d5064978213b
These rules are only obsolete in-so-far as gtester itself should be considered obsolete. If we want to deprecate gtester then maybe we should take a more thorough approach here -- gnome goal, etc.