After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709814 - [examples/overlay] avoid to unref sink if not found. Also fix logic to find a sink in one of the example.
[examples/overlay] avoid to unref sink if not found. Also fix logic to find a...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal minor
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-10 13:17 UTC by Julien Isorce
Modified: 2013-10-11 21:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
unref sink only when found (2.45 KB, patch)
2013-10-10 13:17 UTC, Julien Isorce 		committed Details | Review
handle the case when xvimagesink is not found (2.47 KB, patch)
2013-10-10 13:18 UTC, Julien Isorce 		committed Details | Review

Description Julien Isorce 2013-10-10 13:17:53 UTC 
Created attachment 256903 [details] [review]
unref sink only when found

Spotted because I have ximagesink but not xvimagesink:

For gtk-videooverlay and qt-videooverlay, the sink is unref even if not found.

For qtgv-videooverlay the logic to find the sink is wrong. If the first sink is not found them it do not check for the next.
Comment 1 Julien Isorce 2013-10-10 13:18:44 UTC 
Created attachment 256904 [details] [review]
handle the case when xvimagesink is not found
Comment 2 Sebastian Dröge (slomo) 2013-10-10 13:20:10 UTC 
Comment on attachment 256904 [details] [review]
handle the case when xvimagesink is not found

What about using autovideosink as a last fallback additionally?
Comment 3 Julien Isorce 2013-10-10 14:55:37 UTC 
Yes and maybe it should just use only autovideosink.
Comment 4 Julien Isorce 2013-10-10 15:21:56 UTC 
commit 973d1dcf39308a01f79b9bafe6bfa288523a1f0b
Author: Julien Isorce <julien.isorce@collabora.co.uk>
Date:   Thu Oct 10 14:09:19 2013 +0100

    examples/overlay: handle the case when xvimagesink is not found
    
    So that ximagesink can have a chance to be found.
    In qtgv-videooverlay.

commit e0dfbe9dfaabe9ca5828885f8d8b16433223aa5f
Author: Julien Isorce <julien.isorce@collabora.co.uk>
Date:   Thu Oct 10 14:01:44 2013 +0100

    examples/overlay: unref sink only when found
    
    In gtk-videooverlay and qt-videooverlay examples.
Comment 5 Tim-Philipp Müller 2013-10-11 21:31:35 UTC 
Please try to add bugzilla links (or bug numbers) to commit messages, and set the target milestone to the next stable release which will contain the fix (or next dev release if only pushed to master). Thanks!