After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709685 - More fixes to airplane mode.
More fixes to airplane mode.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 709684
Blocks:
 
 
Reported: 2013-10-08 21:44 UTC by Giovanni Campagna
Modified: 2014-02-04 21:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
AirplaneMode: don't show a "Turn off" item if HW enabled (1.91 KB, patch)
2013-10-08 21:44 UTC, Giovanni Campagna 		accepted-commit_now Details | Review
AirplaneMode: show a different status when enabled by HW (1.67 KB, patch)
2013-10-08 21:44 UTC, Giovanni Campagna 		accepted-commit_now Details | Review
AirplaneMode: don't show a "Turn off" item if HW enabled (2.09 KB, patch)
2014-01-28 22:31 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-10-08 21:44:08 UTC 
Depend on bug 709684 for the new API in gsd.
Also, patch 2 breaks string freeze, and the new string is quite bad
(too long), but I can't think of anything else.
Comment 1 Giovanni Campagna 2013-10-08 21:44:10 UTC 
Created attachment 256767 [details] [review]
AirplaneMode: don't show a "Turn off" item if HW enabled

If airplane mode is enabled with an HW switch, we can't turn it
off from the menu, so hide the menu item.
Comment 2 Giovanni Campagna 2013-10-08 21:44:15 UTC 
Created attachment 256768 [details] [review]
AirplaneMode: show a different status when enabled by HW

This would explain to the user why there is no "Turn off" item,
and what he needs to do to turn airplane mode off.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-10-08 22:37:24 UTC 
gnome-settings-daemon patch / bug?
Comment 4 drago01 2013-10-10 06:49:43 UTC 
(In reply to comment #3)
> gnome-settings-daemon patch / bug?

Bug 709684 ? (i.e the one in comment 1 / depends) or do you mean something else?
Comment 5 Florian Müllner 2013-11-12 16:09:20 UTC 
Review of attachment 256767 [details] [review]:

OK
Comment 6 Florian Müllner 2013-11-12 16:10:29 UTC 
Review of attachment 256768 [details] [review]:

Looks good to me for master.

If we want this on 3-10, we will need to ask for a string freeze break.
Comment 7 Rui Matos 2013-11-12 16:28:19 UTC 
Review of attachment 256768 [details] [review]:

::: js/ui/status/rfkill.js
@@ +57,3 @@
+
+        if (hwAirplaneMode)
+            this._item.status.text = _("Hardware Enabled");

This should be "Hardware Disabled" right? And we should probably have design feedback for this.
Comment 8 Allan Day 2013-11-13 13:12:38 UTC 
We discussed this on IRC yesterday. One possibility for the hardware switch case is to make the "Turn Off" menu insensitive and change the label to "Use hardware switch to turn off" or similar.
Comment 9 Giovanni Campagna 2014-01-28 22:31:56 UTC 
Created attachment 267453 [details] [review]
AirplaneMode: don't show a "Turn off" item if HW enabled

If airplane mode is enabled with an HW switch, we can't turn it
off from the menu, so make the menu item insensitive and
replace it with a helpful tip.
Comment 10 Jasper St. Pierre (not reading bugmail) 2014-01-28 22:49:26 UTC 
Review of attachment 267453 [details] [review]:

Looks good.
Comment 11 Giovanni Campagna 2014-02-04 21:25:14 UTC 
Attachment 267453 [details] pushed as df3a50b - AirplaneMode: don't show a "Turn off" item if HW enabled