After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709588 - encodebin: Handle changes in encoding_profile::restriction during playback
encodebin: Handle changes in encoding_profile::restriction during playback
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-07 17:58 UTC by Thibault Saunier
Modified: 2013-10-11 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
encodebin: Handle changes in encoding_profile::restriction during playback (6.01 KB, patch)
2013-10-07 17:58 UTC, Thibault Saunier 		committed Details | Review

Description Thibault Saunier 2013-10-07 17:58:14 UTC 
There are cases where we want to change the restrictions caps during
playback, handle that in encodebin.
Comment 1 Thibault Saunier 2013-10-07 17:58:24 UTC 
Created attachment 256652 [details] [review]
encodebin: Handle changes in encoding_profile::restriction during playback
Comment 2 Sebastian Dröge (slomo) 2013-10-08 10:16:14 UTC 
Review of attachment 256652 [details] [review]:

Looks good in general but:

::: gst-libs/gst/pbutils/encoding-profile.c
@@ +223,3 @@
+        caps = gst_caps_copy (prof->restriction);
+
+      gst_value_set_caps (value, caps);

Why copy the caps? Why not just gst_value_set_caps (value, prof->restriction)?
Comment 3 Thibault Saunier 2013-10-08 11:57:03 UTC 
Review of attachment 256652 [details] [review]:

::: gst-libs/gst/pbutils/encoding-profile.c
@@ +223,3 @@
+        caps = gst_caps_copy (prof->restriction);
+
+      gst_value_set_caps (value, caps);

So that we do not end up with read only caps on encodebin, not sure it was necessary indeed.
Comment 4 Sebastian Dröge (slomo) 2013-10-09 15:56:56 UTC 
Then don't and push :)
Comment 5 Thibault Saunier 2013-10-09 18:29:51 UTC 
Attachment 256652 [details] pushed as 4305e1c - encodebin: Handle changes in encoding_profile::restriction during playback