GNOME Bugzilla – Bug 709522
[PATCH] GtkFileChooser sidebar is not populated since 742a2f11
Last modified: 2013-10-31 12:19:22 UTC
Created attachment 256583 [details] [review] Populate GtkPlacesSidebar at initialization This commit introduced a regression in GtkFileChooser: commit 742a2f11a95a1e9ce56fe1a628743c7e8add8a57 Author: Cosimo Cecchi <cosimoc@gnome.org> Date: Mon Jan 21 18:04:14 2013 -0500 Remove useless style_set override Previously, the "Places" sidebar was populated by the update_places() call from within gtk_places_sidebar_style_set(). Now, update_places() is never called and the sidebar is never populated unless gtk_places_sidebar_add_shortcut() happens to be called. The attached patch fixes this by calling update_places() at the end of gtk_places_sidebar_init().
Background, from IRC: <jlindgren> I've got this weird bug where the open dialog doesn't work properly if the current working directory is my home directory. <jlindgren> In any other directory it works fine. <jlindgren> But in my home directory the sidebar doesn't get populated at all. <Company> fun ... <jlindgren> 742a2f11a95a1e9ce56fe1a628743c7e8add8a57 broke the filechooser sidebar. <jlindgren> It's only by chance that it works in other directories calling gtk_places_sidebar_add_shortcut() triggers the sidebar to get populated. <jlindgren> *because calling <Company> looks like an update_places() call is missing somewhere important <jlindgren> Yeah, it probably didn't belong in style_set(), but it needs to be added somewhere else. <Company> right
Attachment 256583 [details] pushed as 17a1f4a - Populate GtkPlacesSidebar at initialization
*** Bug 711193 has been marked as a duplicate of this bug. ***