After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709443 - datetime: Critical warnings after recent memory management fixes
datetime: Critical warnings after recent memory management fixes
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Date and Time
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: Zeeshan Ali
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-04 18:27 UTC by Kalev Lember
Modified: 2013-10-07 10:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
datetime: Store am_pm_stack in priv structure (4.19 KB, patch)
2013-10-04 18:30 UTC, Kalev Lember 		committed Details | Review
datetime: Disconnect from GtkStack signals before widget destruction (2.19 KB, patch)
2013-10-04 18:30 UTC, Kalev Lember 		committed Details | Review
Revert "datetime: Don't leak the dialogs" (3.16 KB, patch)
2013-10-04 18:30 UTC, Kalev Lember 		committed Details | Review
datetime: Explicitly destroy toplevel dialogs (1.50 KB, patch)
2013-10-04 18:30 UTC, Kalev Lember 		committed Details | Review

Description Kalev Lember 2013-10-04 18:27:07 UTC 
After commit 545c8865434314739d86df6a656a2461e7d1b609, I am getting criticals when opening the datetime panel:

Gtk-CRITICAL **: gtk_widget_hide: assertion 'GTK_IS_WIDGET (widget)' failed

Gtk-CRITICAL **: gtk_widget_hide: assertion 'GTK_IS_WIDGET (widget)' failed

... and leaving:

Gtk-CRITICAL **: gtk_builder_get_object: assertion 'GTK_IS_BUILDER (builder)' failed

Gtk-CRITICAL **: gtk_widget_get_accessible: assertion 'GTK_IS_WIDGET (widget)' failed
Comment 1 Kalev Lember 2013-10-04 18:30:30 UTC 
Created attachment 256495 [details] [review]
datetime: Store am_pm_stack in priv structure

This is in preparation for the next patch.
Comment 2 Kalev Lember 2013-10-04 18:30:33 UTC 
Created attachment 256496 [details] [review]
datetime: Disconnect from GtkStack signals before widget destruction

This fixes a regression from commit 545c886 that caused criticals when
leaving the datetime panel.
Comment 3 Kalev Lember 2013-10-04 18:30:43 UTC 
Created attachment 256497 [details] [review]
Revert "datetime: Don't leak the dialogs"

This caused criticals when on_permission_changed callback tried to
access priv->datetime_dialog or priv->timezone_dialog before they had
been set up.

Another attempt at fixing the leak in the following patch.

This reverts commit 545c8865434314739d86df6a656a2461e7d1b609.
Comment 4 Kalev Lember 2013-10-04 18:30:47 UTC 
Created attachment 256498 [details] [review]
datetime: Explicitly destroy toplevel dialogs
Comment 5 Rui Matos 2013-10-04 19:19:28 UTC 
Review of attachment 256495 [details] [review]:

ok
Comment 6 Rui Matos 2013-10-04 19:19:56 UTC 
Review of attachment 256496 [details] [review]:

looks good
Comment 7 Rui Matos 2013-10-04 19:20:13 UTC 
Review of attachment 256497 [details] [review]:

++
Comment 8 Rui Matos 2013-10-04 19:20:49 UTC 
Review of attachment 256498 [details] [review]:

Fine. Thanks and sorry for not having noticed these!
Comment 9 Kalev Lember 2013-10-07 10:53:22 UTC 
Thanks for the review!

Attachment 256495 [details] pushed as 2234970 - datetime: Store am_pm_stack in priv structure
Attachment 256496 [details] pushed as 7ae60ad - datetime: Disconnect from GtkStack signals before widget destruction
Attachment 256497 [details] pushed as 47fb0c4 - Revert "datetime: Don't leak the dialogs"
Attachment 256498 [details] pushed as 24faa84 - datetime: Explicitly destroy toplevel dialogs