After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709442 - Expand tab width
Expand tab width
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-04 18:26 UTC by William Jon McCann
Modified: 2013-10-17 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Expand tabs (910 bytes, patch)
2013-10-04 18:27 UTC, William Jon McCann
committed Details | Review
Center tab labels (1.29 KB, patch)
2013-10-04 18:27 UTC, William Jon McCann
committed Details | Review
screenshot (after) (32.77 KB, image/png)
2013-10-04 18:28 UTC, William Jon McCann
  Details

Description William Jon McCann 2013-10-04 18:26:47 UTC
I think it is much nicer to make tabs expand to use the entire available width. This is consistent with our recommendations for other applications as well.
Comment 1 William Jon McCann 2013-10-04 18:27:21 UTC
Created attachment 256491 [details] [review]
Expand tabs
Comment 2 William Jon McCann 2013-10-04 18:27:24 UTC
Created attachment 256492 [details] [review]
Center tab labels
Comment 3 William Jon McCann 2013-10-04 18:28:06 UTC
Created attachment 256493 [details]
screenshot (after)
Comment 4 Paolo Borelli 2013-10-05 14:45:18 UTC
Uhm... I know that the whole tab design is a work in progress so do not take this as a hard "no", but to be honest I do not like the result very much.

It is hard to articulate whether what I do not like is due to the expansion/centering proposed in this bug report and how much it is due to the new tab design, so I'll just report my general feedback

Among other things

1) it is very unfamiliar to all the tabbed UIs on all major platforms
2) the close button seems just floating at random points in space
3) I find the indication of "current" tab too subtle
Comment 5 Ignacio Casal Quinteiro (nacho) 2013-10-13 11:53:22 UTC
I guess this needs now an update?
Comment 6 Paolo Borelli 2013-10-13 12:20:46 UTC
we can try to push the centering/expand thing and see how things look... it cannot be much worse of what is there now :-(


Beside my general dislike for the new look for the reasons stated above, here is a list of things that are broken with the new design:

 * the tabs take *a lot* more vertical space which is not only annoying with lower resolutions, but also completely broke alignment of the sidebar and the vertical centering of the label in the tab

 * the tabs have a weird behavior when they trigger the "scrolling mode", they suddenly become wider with a lot of space between the label and the close button

 * the tabs take too much space which means we trigger the scrolling mode sooner, which in turn sucks

 * the tabs attached at the bottom of a notebook (e.g. the sidepane pages) have the "current page" highlighting at the bottom, while I guess it should be at the top (near the notebook content)

 * in general the new look does not work at all for the sidepane since it is too small and hard to see
Comment 7 Ignacio Casal Quinteiro (nacho) 2013-10-17 13:53:29 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 8 Ignacio Casal Quinteiro (nacho) 2013-10-17 13:56:59 UTC
See though that even if this bug is closed since it is actually fixed, the comments from pbor are still there.