GNOME Bugzilla – Bug 709440
Fix overloading of "source" and "target" terminology in GBinding
Last modified: 2013-10-06 18:25:59 UTC
GBindingTransformFunc called its arguments "source_value" and "target_value", but in the transform_from function of a bidirectional binding, "source_value" comes from the target object, and "target_value" comes from the source object, which quickly gets confusing if you need to use g_binding_get_source(), etc, in the function. Of course developers can call their transform function arguments whatever they want, but many will copy from the headers/docs to start out, so make use less confusing names here ("from_value" and "to_value"). Also, fix the documentation to describe the bidirectional case correctly.
Created attachment 256489 [details] [review] Fix overloading of "source" and "target" terminology in GBinding
Review of attachment 256489 [details] [review]: Thats a lot clearer, thanks.
Attachment 256489 [details] pushed as 8e17040 - Fix overloading of "source" and "target" terminology in GBinding