After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709367 - no grouping in Photos view
no grouping in Photos view
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-10-03 13:59 UTC by Jakub Steiner
Modified: 2014-01-14 10:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
search-type: Use better defaults for "filter" and "where" (2.30 KB, patch)
2013-10-09 15:58 UTC, Debarshi Ray
committed Details | Review
search-type-manager: Clean up (4.64 KB, patch)
2013-10-09 15:59 UTC, Debarshi Ray
committed Details | Review
view-model: Skip collections in the overview (2.14 KB, patch)
2013-10-09 16:00 UTC, Debarshi Ray
committed Details | Review
tracker-controller, query-builder: Simplify the use of PhotosQueryFlags (15.50 KB, patch)
2014-01-14 08:42 UTC, Debarshi Ray
committed Details | Review
base-manager: Be careful about objects with blank filters (1.64 KB, patch)
2014-01-14 08:43 UTC, Debarshi Ray
committed Details | Review
Detect creation of collections and show albums within albums (6.43 KB, patch)
2014-01-14 08:43 UTC, Debarshi Ray
committed Details | Review

Description Jakub Steiner 2013-10-03 13:59:40 UTC
I believe the only place when photos should be grouped is the Albums view. The Photos view is supposed to be a flat recency based grid.
Comment 1 Debarshi Ray 2013-10-09 15:58:46 UTC
Created attachment 256827 [details] [review]
search-type: Use better defaults for "filter" and "where"
Comment 2 Debarshi Ray 2013-10-09 15:59:12 UTC
Created attachment 256829 [details] [review]
search-type-manager: Clean up
Comment 3 Debarshi Ray 2013-10-09 16:00:07 UTC
Created attachment 256831 [details] [review]
view-model: Skip collections in the overview
Comment 4 Debarshi Ray 2014-01-14 07:41:01 UTC
This lead to a regression where newly created albums would not show up immediately, and if albums had other albums inside them you would not be able to see them.
Comment 5 Debarshi Ray 2014-01-14 08:42:06 UTC
Created attachment 266233 [details] [review]
tracker-controller, query-builder: Simplify the use of PhotosQueryFlags
Comment 6 Debarshi Ray 2014-01-14 08:43:12 UTC
Created attachment 266234 [details] [review]
base-manager: Be careful about objects with blank filters
Comment 7 Debarshi Ray 2014-01-14 08:43:52 UTC
Created attachment 266235 [details] [review]
Detect creation of collections and show albums within albums