After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709326 - GDesktopAppInfo crashes creating a DBusActivatable app without a filename
GDesktopAppInfo crashes creating a DBusActivatable app without a filename
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 710521 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-02 23:24 UTC by Giovanni Campagna
Modified: 2013-10-22 14:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
appinfo: Don't try DBusActivatable with load_from_keyfile (1016 bytes, patch)
2013-10-03 14:03 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Giovanni Campagna 2013-10-02 23:24:43 UTC 
If you create a GDesktopAppInfo without a filename, and make it have the DBusActivatable=true flag, then you get a crash, because the loading code relies on the filename unconditionally.

This could happen through new_from_keyfile(), or from the desktop file index Ryan is working on.
Comment 1 Allison Karlitskaya (desrt) 2013-10-03 14:03:12 UTC 
Created attachment 256390 [details] [review]
appinfo: Don't try DBusActivatable with load_from_keyfile

We can't get the name of the filename, so we can't determine the application
ID.  We'll have to fallback on Exec= for this case.
Comment 2 Colin Walters 2013-10-03 15:31:05 UTC 
Review of attachment 256390 [details] [review]:

Looks right.
Comment 3 Allison Karlitskaya (desrt) 2013-10-04 16:19:13 UTC 
Attachment 256390 [details] pushed as e0ffd5c - appinfo: Don't try DBusActivatable with load_from_keyfile
Comment 4 Allison Karlitskaya (desrt) 2013-10-22 14:18:10 UTC 
*** Bug 710521 has been marked as a duplicate of this bug. ***