After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709221 - shell: unref correct proxy on destroy
shell: unref correct proxy on destroy
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-01 18:29 UTC by Ray Strode [halfline]
Modified: 2013-10-01 19:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: unref correct proxy on destroy (2.27 KB, patch)
2013-10-01 18:29 UTC, Ray Strode [halfline] 		reviewed Details | Review
shell: unref correct proxy on destroy (2.37 KB, patch)
2013-10-01 19:27 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2013-10-01 18:29:01 UTC 
gsm-shell.c tries to automatically clear it's reference to the
EndSessionDialog proxy when the proxy is destroyed.

It accidentally unrefs the wrong object though.  This commit
fixes that by changing the open coded unref+nullify to g_clear_object
Comment 1 Ray Strode [halfline] 2013-10-01 18:29:18 UTC 
Created attachment 256205 [details] [review]
shell: unref correct proxy on destroy
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-10-01 18:45:34 UTC 
Review of attachment 256205 [details] [review]:

This is correct, but could the commit message explain a bit more about what this actually fixes, and how severe a bug it is?
Comment 3 Ray Strode [halfline] 2013-10-01 19:26:15 UTC 
weird that i filed this against gnome-shell...
Comment 4 Ray Strode [halfline] 2013-10-01 19:27:19 UTC 
Created attachment 256209 [details] [review]
shell: unref correct proxy on destroy

gsm-shell.c tries to automatically clear it's reference to the
EndSessionDialog proxy when the proxy is destroyed.

It accidentally unrefs the wrong object though.  This commit
fixes that by changing the open coded unref+nullify to g_clear_object

I believe this will address this crasher:

https://retrace.fedoraproject.org/faf/problems/1214348/
Comment 5 Ray Strode [halfline] 2013-10-01 19:27:49 UTC 
Attachment 256209 [details] pushed as 15e263a - shell: unref correct proxy on destroy