After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709168 - The number assigned to the displays does not match the description
The number assigned to the displays does not match the description
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-01 09:49 UTC by Michael Monreal
Modified: 2013-10-04 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (109.75 KB, image/png)
2013-10-01 09:49 UTC, Michael Monreal 		  Details
display: always label the built in display as "1" (2.91 KB, patch)
2013-10-04 10:53 UTC, Thomas Wood 		needs-work Details | Review
display: always label the built in display as "1" (5.10 KB, patch)
2013-10-04 14:04 UTC, Thomas Wood 		committed Details | Review

Description Michael Monreal 2013-10-01 09:49:01 UTC 
Created attachment 256168 [details]
Screenshot

My "primary" display is listed as display "2" while the "secondary is "1", which is confusing.
Comment 1 Bastien Nocera 2013-10-01 13:51:19 UTC 
But if you were to switch the primary monitor to be the one marked "1" it would be right...

I think that might be one of the reasons we used colours in the past.
Comment 2 Michael Monreal 2013-10-01 15:42:21 UTC 
Alright I got this wrong, I was under the impression the internal display was always called the primary display, but the primary display is the one with the panel... still very confusing (or even more so now)
Comment 3 Thomas Wood 2013-10-04 10:53:43 UTC 
Created attachment 256459 [details] [review]
display: always label the built in display as "1"
Comment 4 Bastien Nocera 2013-10-04 11:42:03 UTC 
Review of attachment 256459 [details] [review]:

As mentioned on IRC, this doesn't seem to reorder the displays in the panel itself.
Comment 5 Thomas Wood 2013-10-04 14:04:07 UTC 
Created attachment 256477 [details] [review]
display: always label the built in display as "1"
Comment 6 Bastien Nocera 2013-10-04 14:12:20 UTC 
Review of attachment 256477 [details] [review]:

::: panels/display/cc-display-panel.c
@@ +418,3 @@
+
+      /* ensure the built in display is first in the list */
+      if (gnome_rr_output_is_builtin_display (output))

That should be the primary monitor (the one labelled "1") first, not the builtin monitor.
Comment 7 Thomas Wood 2013-10-04 15:10:08 UTC 
(In reply to comment #6)
> Review of attachment 256477 [details] [review]:
> 
> ::: panels/display/cc-display-panel.c
> @@ +418,3 @@
> +
> +      /* ensure the built in display is first in the list */
> +      if (gnome_rr_output_is_builtin_display (output))
> 
> That should be the primary monitor (the one labelled "1") first, not the
> builtin monitor.

As discussed on IRC, labelling the built in display as "1" was the intended solution.
Comment 8 Thomas Wood 2013-10-04 15:10:47 UTC 
Attachment 256477 [details] pushed as 17126cc - display: always label the built in display as "1"
Comment 9 Bastien Nocera 2013-10-04 15:11:01 UTC 
Review of attachment 256477 [details] [review]:

Never mind, we said that we should show the internal display first, not the primary...