After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709102 - gstvaapifilter requires va api 0.33
gstvaapifilter requires va api 0.33
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-30 14:51 UTC by Víctor Manuel Jáquez Leal
Modified: 2013-10-01 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
filter: guard 0.34 symbols (1.88 KB, patch)
2013-09-30 15:13 UTC, Víctor Manuel Jáquez Leal 		none Details | Review

Description Víctor Manuel Jáquez Leal 2013-09-30 14:51:42 UTC 
gstvaapifilter uses the symbol VAProcFilterParameterBufferType, which was introduced in the VA API 0.33.0, meanwhile the configure.ac only requires 0.30.4.

The simplest solution would be bump the required libav api version. A better approach (IMO) would be use conditional compilation.
Comment 1 Víctor Manuel Jáquez Leal 2013-09-30 15:13:07 UTC 
Created attachment 256097 [details] [review]
filter: guard 0.34 symbols

VASurfaceAttrib and VAProcFilterParameterBufferType are symbols
that need to be guarded for libva 0.34 and 0.33, respectively.
Comment 2 Gwenole Beauchesne 2013-09-30 15:54:47 UTC 
There normally is a check for VA/VPP APIs in the configure script. Do you mean it is inacurate or regressed since my initial testing? Could you please attach your config.log file? It seems you probably have a stale va_vpp.h file somewhere.
Comment 3 Víctor Manuel Jáquez Leal 2013-09-30 16:18:55 UTC 
(In reply to comment #2)
> There normally is a check for VA/VPP APIs in the configure script. Do you mean
> it is inacurate or regressed since my initial testing? Could you please attach
> your config.log file? It seems you probably have a stale va_vpp.h file
> somewhere.

The VA/VPP API works, but there's a missing #if USE_VA_VPP  in the code. Look at the patch ;)
Comment 4 Gwenole Beauchesne 2013-10-01 08:36:37 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > There normally is a check for VA/VPP APIs in the configure script. Do you mean
> > it is inacurate or regressed since my initial testing? Could you please attach
> > your config.log file? It seems you probably have a stale va_vpp.h file
> > somewhere.
> 
> The VA/VPP API works, but there's a missing #if USE_VA_VPP  in the code. Look
> at the patch ;)

You are right, sorry. :)

However, I would make ensure_formats() simply return NULL if VA-API < 0.34.0 since filter->formats is never set anyway in this case.
Comment 5 Gwenole Beauchesne 2013-10-01 16:55:30 UTC 
Applied, thanks.
Comment 6 Gwenole Beauchesne 2013-10-01 16:55:45 UTC 
commit 94b554e7a233cb1741ac586a169c132a32a4c006
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Mon Sep 30 17:08:12 2013 +0200

    filter: fix VA-API 0.34.0 symbol guards.
    
    VASurfaceAttrib and VAProcFilterParameterBufferType are symbols
    that need to be guarded for libva 0.34 and 0.33, respectively.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=709102