After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709056 - icontheme: use g_file_load_contents() for symbolic icons
icontheme: use g_file_load_contents() for symbolic icons
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-09-29 22:44 UTC by Cosimo Cecchi
Modified: 2013-09-30 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
icontheme: use g_file_load_contents() for symbolic icons (1.22 KB, patch)
2013-09-29 22:44 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-09-29 22:44:22 UTC 
See attached patch.
Comment 1 Cosimo Cecchi 2013-09-29 22:44:24 UTC 
Created attachment 256042 [details] [review]
icontheme: use g_file_load_contents() for symbolic icons

When loading a symbolic icon, g_file_get_contents() is currently used
with the icon pathname, to load its SVG data. This won't work when the
icon is not a local file, for instance when a symbolic icon is loaded
from a GFileIcon with a GResource path.
Fortunately GtkIconInfo already holds a GFile, so we can just use
g_file_load_contents() to load the data instead.
Comment 2 Matthias Clasen 2013-09-30 14:47:50 UTC 
Review of attachment 256042 [details] [review]:

Looks fine
Comment 3 Matthias Clasen 2013-09-30 14:48:07 UTC 
Review of attachment 256042 [details] [review]:

Looks fine
Comment 4 Cosimo Cecchi 2013-09-30 16:46:40 UTC 
Attachment 256042 [details] pushed as 3d602f5 - icontheme: use g_file_load_contents() for symbolic icons