After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708501 - osxvideosink: fix segfault releasing the element
osxvideosink: fix segfault releasing the element
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.x
Other Mac OS
: Normal blocker
: 1.2.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-20 22:29 UTC by Andoni Morales
Modified: 2013-09-24 08:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
osxvideosink: fix segfault releasing the sink (1.97 KB, patch)
2013-09-20 22:29 UTC, Andoni Morales 		committed Details | Review

Description Andoni Morales 2013-09-20 22:29:34 UTC 
Created attachment 255449 [details] [review]
osxvideosink: fix segfault releasing the sink

There is a race when the element is released. show_frame defers the rendering to the main thread asynchronously and it might happen when the element has been released.
Comment 1 Sebastian Dröge (slomo) 2013-09-24 08:03:14 UTC 
commit 05f6c094fa0b5f64507cc035b388c7f635c9ee70
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Fri Sep 20 19:43:21 2013 +0200

    osxvideosink: fix segfault releasing the sink
    
    show_frame is deferred to the main thread and can be called
    when the sink has been released, so we need to keep an extra ref
    on ObjectiveC object helper.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708501