After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708256 - St: Fix fade effect
St: Fix fade effect
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-17 17:43 UTC by Carlos Soriano
Modified: 2013-10-18 18:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
St: Fix fade effect (3.49 KB, patch)
2013-09-17 17:43 UTC, Carlos Soriano 		committed Details | Review

Description Carlos Soriano 2013-09-17 17:43:50 UTC 
commit 4095a58eb9a2921c178b30c56d1fbe7662c2778a introduce a
regression, since we have to take into account four cases,
top, bottom, right, and left, and that can't be merged into
two like that commit did.
So fix it to make fade effect works again.
Comment 1 Carlos Soriano 2013-09-17 17:43:53 UTC 
Created attachment 255129 [details] [review]
St: Fix fade effect

commit 4095a58eb9a2921c178b30c56d1fbe7662c2778a introduce a
regression, since we have to take into account four cases,
top, bottom, right, and left, and that can't be merged into
two like that commit did.
So fix it to make fade effect works again.
Comment 2 drago01 2013-09-17 17:46:49 UTC 
Review of attachment 255129 [details] [review]:

Code looks good.

Commit message: "Commit ... " rather then "commit ..."  and "introduced" not "introduce".

Go ahead and ask for a freeze break exception.
Comment 3 Carlos Soriano 2013-09-18 18:13:07 UTC 
Attachment 255129 [details] pushed as c23786c - St: Fix fade effect
Comment 4 John Ralls 2013-10-18 17:47:17 UTC 
*** Bug 704723 has been marked as a duplicate of this bug. ***
Comment 5 Carlos Soriano 2013-10-18 18:18:05 UTC 
Jonh,
I think you duplicated the wrong bug report