After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708154 - Crash when Search button is toggled on No Music view
Crash when Search button is toggled on No Music view
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.9.x
Other Linux
: Normal critical
: ---
Assigned To: gnome-music-maint
gnome-music-maint
: 720329 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-09-16 12:24 UTC by Arnel Borja
Modified: 2014-02-10 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the crash if no musinc is in the library (2.19 KB, patch)
2013-12-24 22:47 UTC, Gian Mario Tagliaretti 		rejected Details | Review

Description Arnel Borja 2013-09-16 12:24:30 UTC 
The title says it all ;)
Comment 1 André Klapper 2013-09-17 09:06:20 UTC 
Normally I'd write: Stacktrace welcome (in case other could not reproduce it).
Comment 2 Vladimir Didenko 2013-10-06 12:04:55 UTC 
(In reply to comment #1)
> Normally I'd write: Stacktrace welcome (in case other could not reproduce it).

From my machine

Traceback (most recent call last):

+ Trace 232577

  • File "/usr/lib/python3.3/site-packages/gnomemusic/searchbar.py", line 45 in prepare_search_filter 
    self.view = self.stack_switcher.get_stack().get_visible_child()
AttributeError: 'NoneType' object has no attribute 'get_visible_child' 






Comment 3


Arnel Borja





          2013-10-07 14:34:22 UTC
        



(In reply to comment #2)
> (In reply to comment #1)
> > Normally I'd write: Stacktrace welcome (in case other could not reproduce it).
> 
> From my machine
> 
> Traceback (most recent call last):
> 

Thanks! I am busy lately so I don't have time to update this bug.






Comment 4


Vadim Rutkovsky





          2013-12-12 14:22:00 UTC
        



*** Bug 720329 has been marked as a duplicate of this bug. ***






Comment 5


Gian Mario Tagliaretti





          2013-12-24 22:47:29 UTC
        



Created attachment 264859 [details] [review]
Fix the crash if no musinc is in the library

Popup a friendly message if the search button is pressed with no music in the library






Comment 6


Vadim Rutkovsky





          2014-02-07 11:01:01 UTC
        



Review of attachment 264859 [details] [review]:

I don't think we need another message for user when there is no music present






Comment 7


Vadim Rutkovsky





          2014-02-10 15:10:54 UTC
        



Fixed in https://git.gnome.org/browse/gnome-music/commit/?id=1aa17a3