After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708106 - mpegtspacketizer: Incorrect condition checking
mpegtspacketizer: Incorrect condition checking
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.1.4
Other Linux
: Normal normal
: 1.1.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-15 11:47 UTC by Sudip Jain
Modified: 2013-09-18 16:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for correct conditon check. (951 bytes, patch)
2013-09-15 11:47 UTC, Sudip Jain 		committed Details | Review

Description Sudip Jain 2013-09-15 11:47:51 UTC 
Created attachment 254967 [details] [review]
patch for correct conditon check.

The condition check for current_next_indicator in the function mpegts_packetizer_push_section is incorrect I assume. 

The (G_UNLIKELY (!data & 0x01)) will always return false irrespective of the value in the data pointer.

Patch is attached for this fix

-sudipj
Comment 1 Sebastian Dröge (slomo) 2013-09-16 09:01:01 UTC 
commit 27739e8bb68e085b518864dd6db2198c2069f292
Author: Sudip Jain <sudip.jain@st.com>
Date:   Sun Sep 15 17:09:16 2013 +0530

    mpegtspacketizer: Correct condition check for current next indicator
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708106