GNOME Bugzilla – Bug 707999
HeaderBar height increases when the subtitle label is set and visible
Last modified: 2014-02-17 12:25:17 UTC
Each application which use GtkHeaderBar and set title (also title without subtitle), is too height. For example, gnome-clocks in the overview (there isn't title, have stack instead), the height is good. In city page, have title (and subtitle, in this case), and the headerbar is too height. See screenshots.
Created attachment 254824 [details] Screenshot - gnome-clocks world
Created attachment 254825 [details] Screenshot - gnome-clocks city
This is because title+subtitle require this much height. Either we need to come up with a more cramped design for those two, or give up on two-line titles.
So should I work around this in gnome-tweak-tool and pack my own label?
(In reply to comment #4) > So should I work around this in gnome-tweak-tool and pack my own label? I not understand what gnome-tweak-tool relate to this bug?
(In reply to comment #4) > So should I work around this in gnome-tweak-tool and pack my own label? Here is what the headerbar docs say: * Note that GtkHeaderBar always reserves room for the subtitle, even * if none is currently set. If this is not desired, use * gtk_header_bar_set_custom_title().
Created attachment 255050 [details] Screenshot - too much space (In reply to comment #6) > (In reply to comment #4) > > So should I work around this in gnome-tweak-tool and pack my own label? > > Here is what the headerbar docs say: > > * Note that GtkHeaderBar always reserves room for the subtitle, even > * if none is currently set. If this is not desired, use > * gtk_header_bar_set_custom_title(). I think GtkHeaderBar saved too much room for the subtitle. See the screenshot.
Cosimo, any opinion on adding a way to 'unreserve' the subtitle space ?
Matthias, as you said I think if people want to avoid that, they should pack their own title widget. I don't think it buys us anything to make it easier than that. I think the problem here might be that the Hebrew font used by Yosef has a larger height than the usual Cantarell, and the vertical paddings become inconsistent between the two views - the header bar shouldn't change size between different pages.
Created attachment 255056 [details] Screenshot - gnome-clocks just in English with Cantarell 11 (In reply to comment #9) > I think the problem here might be that the Hebrew font used by Yosef has a > larger height than the usual Cantarell, and the vertical paddings become > inconsistent between the two views - the header bar shouldn't change size > between different pages. I think isn't relate to font Hebrew - also in English (Cantarell 11, of course) I get size different between the two views.
(In reply to comment #5) > (In reply to comment #4) > > So should I work around this in gnome-tweak-tool and pack my own label? > > I not understand what gnome-tweak-tool relate to this bug? Its just a +1 to your list of applications that cannot use the (simple) headerbar api without looking different to the rest.
(In reply to comment #9) > Matthias, as you said I think if people want to avoid that, they should pack > their own title widget. I don't think it buys us anything to make it easier > than that. If I pack my own label I guess I need to add the style class (title?) that renders the font bold, like the other header bars. Is that correct?
(In reply to comment #12) > If I pack my own label I guess I need to add the style class (title?) that > renders the font bold, like the other header bars. Is that correct? If you want the same style for the title, yes.
(In reply to comment #9) ... > I think the problem here might be that the Hebrew font used by Yosef has a > larger height than the usual Cantarell, and the vertical paddings become > inconsistent between the two views - the header bar shouldn't change size > between different pages. I think it's a more general problem - the header bar gets taller even with Cantarell. We have a few other bugs that I reported about this: bug 706485 - contacts - HeaderBar is too tall bug 706515 - gtk+ - HeaderBars are sometimes too tall bug 706431 - gnome-themes-standard - HeaderBar grows taller in clocks view Maybe we need to give up on the idea of having sub-headings inside header bars...
re-titling for clarity
Created attachment 265532 [details] modified screenshot After experimenting with this, it seems that it is possible - at least visually - to fit in a sub-heading within the desired spacing. This can be seen in the attachment, which is a modified screenshot of gedit redesign branch.
Thanks so much for fixing this, Matthias.