After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707935 - dnd: Remove the queue updated ID for completed drags as well
dnd: Remove the queue updated ID for completed drags as well
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-11 19:10 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-09-11 19:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dnd: Remove the queue updated ID for completed drags as well (1.42 KB, patch)
2013-09-11 19:10 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-09-11 19:10:24 UTC 
See patch.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-09-11 19:10:26 UTC 
Created attachment 254733 [details] [review]
dnd: Remove the queue updated ID for completed drags as well

I thought that cancelDrag was called for completed drags as well,
but it's not. Move the updateHoverId source removal to dragComplete.

This fixes "this._dragActor is undefined" warnings after completed
drags.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-09-11 19:26:03 UTC 
Attachment 254733 [details] pushed as 744749f - dnd: Remove the queue updated ID for completed drags as well


<drago01> Jasper: so if testing (both cancel with button release and esc) still works acn