After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707889 - Fix workspace error spam from the overview
Fix workspace error spam from the overview
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-11 00:45 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-09-11 14:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspace: Clean up a leftover later_add on destroy (795 bytes, patch)
2013-09-11 00:46 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
workspacesView: Don't double-destroy workspaces (2.04 KB, patch)
2013-09-11 00:46 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-09-11 00:45:58 UTC 
This is incredibly simple to reproduce: when in the overview, click
on a workspace thumbnail to exit the overview. You'll get some spam
about destroyed actors, and the next time you go into the overview,
the thumbnails won't be there. The spam is because workspace actors
are getting double-destroyed, and we leak a later_add.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-09-11 00:46:01 UTC 
Created attachment 254636 [details] [review]
workspace: Clean up a leftover later_add on destroy
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-09-11 00:46:04 UTC 
Created attachment 254637 [details] [review]
workspacesView: Don't double-destroy workspaces

The WorkspaceView actors contain the Workspace actors, so destroying the
WorkspaceView actors should be enough.
Comment 3 Giovanni Campagna 2013-09-11 07:26:12 UTC 
Review of attachment 254637 [details] [review]:

Is this true for detached workspaces (workspace-only-on-primary == true)?
Comment 4 Giovanni Campagna 2013-09-11 07:27:25 UTC 
Review of attachment 254636 [details] [review]:

Ok
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-09-11 13:59:55 UTC 
(In reply to comment #3)
> Review of attachment 254637 [details] [review]:
> 
> Is this true for detached workspaces (workspace-only-on-primary == true)?

Yes.
Comment 6 Giovanni Campagna 2013-09-11 14:09:44 UTC 
(In reply to comment #5)
> (In reply to comment #3)
> > Review of attachment 254637 [details] [review] [details]:
> > 
> > Is this true for detached workspaces (workspace-only-on-primary == true)?
> 
> Yes.

You're right, ok then.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-09-11 14:16:03 UTC 
Attachment 254636 [details] pushed as 25318f6 - workspace: Clean up a leftover later_add on destroy
Attachment 254637 [details] pushed as f8234b0 - workspacesView: Don't double-destroy workspaces