After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707812 - lib: Remove easy to forget constant
lib: Remove easy to forget constant
Status: RESOLVED FIXED
Product: geocode-glib
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: geocode-glib maintainer(s)
geocode-glib maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-09 22:58 UTC by Bastien Nocera
Modified: 2013-09-16 17:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
lib: Remove easy to forget constant (1.23 KB, patch)
2013-09-09 22:58 UTC, Bastien Nocera 		accepted-commit_now Details | Review

Description Bastien Nocera 2013-09-09 22:58:21 UTC 
.
Comment 1 Bastien Nocera 2013-09-09 22:58:22 UTC 
Created attachment 254528 [details] [review]
lib: Remove easy to forget constant

The constant was defined, unused in the declaration of the
array it was supposed to tell the length of, and used more than
200 lines down.

Instead, remove all constants, and use G_N_ELEMENTS() for our
use inside the function. It will get turned into a constant by
the compiler.
Comment 2 Zeeshan Ali 2013-09-09 23:16:20 UTC 
Review of attachment 254528 [details] [review]:

ACK