After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707790 - gsd exits too early
gsd exits too early
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-09 17:22 UTC by Matthias Clasen
Modified: 2014-02-03 10:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: remove unused code (1.49 KB, patch)
2014-02-03 00:03 UTC, Giovanni Campagna 		committed Details | Review
main: modernize code for handling SIGTERM (2.93 KB, patch)
2014-02-03 00:03 UTC, Giovanni Campagna 		committed Details | Review
main: don't die when gnome-session says Stop (1.24 KB, patch)
2014-02-03 00:03 UTC, Giovanni Campagna 		committed Details | Review

Description Matthias Clasen 2013-09-09 17:22:42 UTC 
With 3.9.91 in f20, I'm experiencing the following:

I click on logut or shutdown in the system status, and immediately, apps loose their theme and their icons - indicating that g-s-d went away. It takes quite a while longer before the shell goes away, and in that time, I get to look at a frankendesktop :-(
Comment 1 Giovanni Campagna 2013-09-25 12:14:25 UTC 
Is this still the case in 3.10?
I don't see it in an updated F20.

In any case it would be good to see if gnome-settings-daemon is crashing, and if abrt picks up something.
Comment 2 Matthias Clasen 2013-09-25 16:18:36 UTC 
haven't noticed it in a while; I will look if it reoccurs
Comment 3 Tobias Mueller 2014-01-20 00:11:58 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!
Comment 4 Giovanni Campagna 2014-02-03 00:01:00 UTC 
I could reproduce this bug on master today, at logout, so this is not fixed.
Comment 5 Giovanni Campagna 2014-02-03 00:03:02 UTC 
Created attachment 267879 [details] [review]
main: remove unused code

The SessionOver signal is legacy and is never emitted by
gnome-session.
Comment 6 Giovanni Campagna 2014-02-03 00:03:08 UTC 
Created attachment 267880 [details] [review]
main: modernize code for handling SIGTERM

Let's use glib's builtin facilities for signals instead of
our own pipe.
Comment 7 Giovanni Campagna 2014-02-03 00:03:13 UTC 
Created attachment 267881 [details] [review]
main: don't die when gnome-session says Stop

gnome-session asks all registered clients to stop after the user
confirms the poweroff/logout dialog, but we should ignore that
request, because non registered applications are still mapped
and they would lose their theme and icons if we die (and same
for the shell).
We will go away as soon as the X11 connection is closed or the
session bus dies anyway.
Comment 8 Bastien Nocera 2014-02-03 10:18:34 UTC 
Review of attachment 267879 [details] [review]:

Fine.
Comment 9 Bastien Nocera 2014-02-03 10:19:55 UTC 
Review of attachment 267880 [details] [review]:

Much nicer indeed.
Comment 10 Bastien Nocera 2014-02-03 10:21:09 UTC 
Review of attachment 267881 [details] [review]:

Looks fine.

You can commit all this to master and gnome-3-10.
Comment 11 Giovanni Campagna 2014-02-03 10:34:56 UTC 
Attachment 267879 [details] pushed as 74a8576 - main: remove unused code
Attachment 267880 [details] pushed as 47ddee7 - main: modernize code for handling SIGTERM
Attachment 267881 [details] pushed as e73148e - main: don't die when gnome-session says Stop