After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707587 - Review gsettings keys
Review gsettings keys
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other Linux
: High normal
: ---
Assigned To: gnome-sudoku-maint
gnome-sudoku-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-05 18:49 UTC by Michael Catanzaro
Modified: 2014-06-12 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove unused gsettings keys (4.16 KB, patch)
2014-06-12 13:51 UTC, Parin Porecha 		committed Details | Review

Description Michael Catanzaro 2013-09-05 18:49:48 UTC 
It looks like some of the gsettings keys are unused.  At least everything starting with generate- is not used anywhere.

These all deserve a quick review.
Comment 1 Michael Catanzaro 2014-06-03 02:11:39 UTC 
Almost all of these keys are unused in master.
Comment 2 Parin Porecha 2014-06-12 13:51:02 UTC 
Created attachment 278344 [details] [review]
Remove unused gsettings keys
Comment 3 Mario Wenzel 2014-06-12 13:56:31 UTC 
Review of attachment 278344 [details] [review]:

Looks fine. Do we really don't need highlight?

::: data/org.gnome.sudoku.gschema.xml
@@ -62,3 @@
       <default>4</default>
     </key>
-    <key name="highlight" type="b">

Didn't we want to reimplement that, even with more subtlety?
Comment 4 Parin Porecha 2014-06-12 16:17:58 UTC 
Comment on attachment 278344 [details] [review]
Remove unused gsettings keys

Ok, I've retained the highlight key.

Patch pushed as 0903986