After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707525 - Last.fm radio stations can't be properly deleted
Last.fm radio stations can't be properly deleted
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: last.fm
unspecified
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-05 00:20 UTC by Jamie Nicol
Modified: 2014-03-08 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
display-page-tree: remove page on remove action (1.13 KB, patch)
2013-09-05 00:20 UTC, Jamie Nicol 		committed Details | Review

Description Jamie Nicol 2013-09-05 00:20:03 UTC 
Pressing the remove button deletes the station, but as soon as you restart
rhythmbox it's back. From what I can see rb_display_page_delete_thyself
is being called instead of rb_display_page_remove? so the radio source
doesn't have a chance to save the fact that it's been deleted.

I'm not quite sure why playlist sources are able to delete themselves
just fine without this change but last.fm ones can't. Maybe I'm
misunderstanding the situation, I haven't dug that deep.
But this seems to fix the problem and not cause any adverse effects.
Comment 1 Jamie Nicol 2013-09-05 00:20:06 UTC 
Created attachment 254138 [details] [review]
display-page-tree: remove page on remove action

Instead of calling rb_display_page_delete_thyself, call
rb_display_page_remove. This allows the page to perform any required
logic before it deletes itself. Audioscrobbler radio sources will now
remain removed after application restart, as they are now able to save
the updated station list upon removal.
Comment 2 Jonathan Matthew 2014-03-08 09:42:02 UTC 
Pushed as commit 14f0637; thanks, and sorry for leaving this sitting around for so long.