After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707387 - PATCH: allow changing effect while recording
PATCH: allow changing effect while recording
Status: RESOLVED WONTFIX
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: 3.8
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-03 13:18 UTC by Hans de Goede
Modified: 2013-09-03 16:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PATCH: allow changing effect while recording (3.48 KB, patch)
2013-09-03 13:18 UTC, Hans de Goede 		rejected Details | Review
PATCH: allow changing effect while recording (3.06 KB, patch)
2013-09-03 16:24 UTC, Hans de Goede 		none Details | Review

Description Hans de Goede 2013-09-03 13:18:14 UTC 
Created attachment 253974 [details] [review]
PATCH: allow changing effect while recording

People having fun with cheese may want to record their fun, and the fun is greatly enhanced if they are able to change the video-effect while recording.
Comment 1 David King 2013-09-03 13:25:28 UTC 
Comment on attachment 253974 [details] [review]
PATCH: allow changing effect while recording

I have no intention of applying this for the foreseeable future.
Comment 2 Hans de Goede 2013-09-03 13:27:33 UTC 
(In reply to comment #1)
> (From update of attachment 253974 [details] [review])
> I have no intention of applying this for the foreseeable future.

David, you know rejecting patches without providing any rationale what so ever for doing so is rather impolite. Even Linus himself does not get away with that.
Comment 3 Hans de Goede 2013-09-03 16:24:41 UTC 
Created attachment 253990 [details] [review]
PATCH: allow changing effect while recording

Since you did not provide any reasons for rejecting the patch I'm groping in the dark here, but I guess you rejected it because it special-cased the video-recording case. Leading to more complicated code.

Here is another approach to offering the same functionality to the user, using a less is more approach from the code pov.
Comment 4 Hans de Goede 2013-09-03 16:26:07 UTC 
Note this patch applies on top of the 2 fixes from bug 707386.