Created attachment 253533 [details] [review]
Remove use of XFixes for showing/hiding the cursor

XFixesShowCursor / XFixesHideCursor does not actually take the suppled
window argument into account -- the effect is actually global. Use
XDefineCursor instead.

Attachment 253533 [details] pushed as 8faae9d - Remove use of XFixes for showing/hiding the cursor

<ebassi> Jasper: I didn't review a patch. next time, ping me
<ebassi> *the patch
<ebassi> Jasper: also, did you actually ask daniels what kind of issue was the XFixes code path trying to solve?
<Jasper> ebassi, so, we went over this a few weeks ago
<Jasper> ebassi, you said you were fine with it as long as daniels was fine with it
<Jasper> ebassi, and daniels said he was fine with it as well.
<ebassi> Jasper: it would have been good to have a Reviewed-by: line, then
<Jasper> ebassi, sorry
<ebassi> there is nothing in either bugzilla *or* the commit log
<Jasper> ebassi, daniels was trying to get rid of a 1x1 cursor he swore he said was on the screen somewhere, but since we set the mask to be be invisible, he shouldn't have seen anything.
<Jasper> So we assumed it was an acceleration bug, and he was fine with it.
<ebassi> Jasper: okay, but really: this stuff needs to be written down somewhere. as X11 becomes legacy, I don't want to have these details committed to the memory of a few people that may or may not stick around for the rest of their lives.