GNOME Bugzilla – Bug 706970
rtpmpvpay: Possible issue with RTP buffer allocation
Last modified: 2013-08-29 11:17:27 UTC
Created attachment 253372 [details] [review] Patch In gst_rtp_mpv_pay_flush() of gstrtpmpvpay.c, RTP buffer allocation should not be done with padding for the specific MPEG2 header as the padding is done at the end of the buffer and the last byte is the size of the padding. Indeed the specific MPEG header is located after the common RTP header. See the provided patch as a solution.
This was accidentially fixed by this commit already: commit 54c5a7f69019376c20e5304371209e4e1df37b86 Author: Olivier Crête <olivier.crete@collabora.com> Date: Tue Jul 16 15:37:49 2013 -0400 rtp: Use gst_adapter_take_buffer_fast() where possible in RTP payloaders
Ok, any idea when it will be pushed on Branch 1.0?
Now :) Just merged your patch, the git master change won't apply and requires API additions in core. commit 5d5787d1face12efdcd906e46754420bc2a5ed79 Author: Paul HENRYS <visechelle@gmail.com> Date: Wed Aug 28 14:23:06 2013 +0200 rtpmpvpay: Fix RTP buffer allocation in rtpmpvpay RTP buffer allocation should not be done with padding for the specific MPEG2 header as the padding is done at the end of the buffer and the last byte is the size of the padding. https://bugzilla.gnome.org/show_bug.cgi?id=706970
Really fast. Thx :)
the master commit: commit d851b8a8b48620c282b0d22f3622f2941ab80dfb Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Thu Aug 29 13:15:15 2013 +0200 rtpmpvpay: Fix RTP buffer allocation in rtpmpvpay RTP buffer allocation should not be done with padding for the specific MPEG2 header as the padding is done at the end of the buffer and the last byte is the size of the padding. https://bugzilla.gnome.org/show_bug.cgi?id=706970