After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706943 - Fix the look of the back button
Fix the look of the back button
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: UI
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-27 23:43 UTC by Yosef Or Boczko
Modified: 2013-08-29 23:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the look of the back button (2.35 KB, patch)
2013-08-27 23:43 UTC, Yosef Or Boczko 		committed Details | Review
out/0002-Remove-utils-bjb-icons-colors.-c-h.patch (1.23 KB, patch)
2013-08-27 23:51 UTC, Yosef Or Boczko 		none Details | Review
Remove utils/bjb-icons-colors.{c,h} (1.73 KB, patch)
2013-08-27 23:56 UTC, Yosef Or Boczko 		none Details | Review
Remove utils/bjb-icons-colors.{c,h} (1.73 KB, patch)
2013-08-27 23:56 UTC, Yosef Or Boczko 		reviewed Details | Review
Remove utils/bjb-icons-colors.{c,h} (2.46 KB, patch)
2013-08-29 23:34 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2013-08-27 23:43:18 UTC 
The back button is bot compatible to other buttons in the headerbar.
See the patch.
Comment 1 Yosef Or Boczko 2013-08-27 23:43:55 UTC 
Created attachment 253331 [details] [review]
Fix the look of the back button
Comment 2 Yosef Or Boczko 2013-08-27 23:51:29 UTC 
Created attachment 253335 [details] [review]
out/0002-Remove-utils-bjb-icons-colors.-c-h.patch
Comment 3 Yosef Or Boczko 2013-08-27 23:56:13 UTC 
Created attachment 253336 [details] [review]
Remove utils/bjb-icons-colors.{c,h}
Comment 4 Yosef Or Boczko 2013-08-27 23:56:36 UTC 
Created attachment 253337 [details] [review]
Remove utils/bjb-icons-colors.{c,h}
Comment 5 Pierre-Yves Luyten 2013-08-29 23:18:41 UTC 
Comment on attachment 253331 [details] [review]
Fix the look of the back button

good
Comment 6 Pierre-Yves Luyten 2013-08-29 23:20:34 UTC 
Comment on attachment 253337 [details] [review]
Remove utils/bjb-icons-colors.{c,h}

>From 2499e7f2fbae958fd8b30712f86a74e36f55142f Mon Sep 17 00:00:00 2001
>From: Yosef Or Boczko <yoseforb@gmail.com>
>Date: Thu, 29 Aug 2013 02:55:09 +0300
>Subject: Remove utils/bjb-icons-colors.{c,h}
>
>They are not used more.
>
>https://bugzilla.gnome.org/show_bug.cgi?id=706943
>---
> src/Makefile.am              |  4 +---
> src/utils/bjb-icons-colors.c | 15 ---------------
> src/utils/bjb-icons-colors.h |  8 --------
> 3 files changed, 1 insertion(+), 26 deletions(-)
> delete mode 100644 src/utils/bjb-icons-colors.c
> delete mode 100644 src/utils/bjb-icons-colors.h
>

Nice cleanup! you shall also remove the include from bjb-main-view.c. I guess you just did not git add this one.


--- a/src/bjb-main-view.c
+++ b/src/bjb-main-view.c
@@ -20,8 +20,6 @@
 #include <libbiji/libbiji.h>
 #include <libgd/gd-main-view.h>
 
-#include "utils/bjb-icons-colors.h"
Comment 7 Yosef Or Boczko 2013-08-29 23:30:26 UTC 
Review of attachment 253331 [details] [review]:

pushed as b14c71a424d70a3db0393e6eec72eabf99dd5bd1- Fix the look of the back button
Comment 8 Yosef Or Boczko 2013-08-29 23:34:47 UTC 
Created attachment 253568 [details] [review]
Remove utils/bjb-icons-colors.{c,h}
Comment 9 Pierre-Yves Luyten 2013-08-29 23:39:56 UTC 
Comment on attachment 253568 [details] [review]
Remove utils/bjb-icons-colors.{c,h}

good
Comment 10 Yosef Or Boczko 2013-08-29 23:47:23 UTC 
Review of attachment 253568 [details] [review]:

pushed as 6f5506c739f560eda9d5012fa6f86bce0090781f - Remove utils/bjb-icons-colors.{c,h}