GNOME Bugzilla – Bug 706943
Fix the look of the back button
Last modified: 2013-08-29 23:58:03 UTC
The back button is bot compatible to other buttons in the headerbar. See the patch.
Created attachment 253331 [details] [review] Fix the look of the back button
Created attachment 253335 [details] [review] out/0002-Remove-utils-bjb-icons-colors.-c-h.patch
Created attachment 253336 [details] [review] Remove utils/bjb-icons-colors.{c,h}
Created attachment 253337 [details] [review] Remove utils/bjb-icons-colors.{c,h}
Comment on attachment 253331 [details] [review] Fix the look of the back button good
Comment on attachment 253337 [details] [review] Remove utils/bjb-icons-colors.{c,h} >From 2499e7f2fbae958fd8b30712f86a74e36f55142f Mon Sep 17 00:00:00 2001 >From: Yosef Or Boczko <yoseforb@gmail.com> >Date: Thu, 29 Aug 2013 02:55:09 +0300 >Subject: Remove utils/bjb-icons-colors.{c,h} > >They are not used more. > >https://bugzilla.gnome.org/show_bug.cgi?id=706943 >--- > src/Makefile.am | 4 +--- > src/utils/bjb-icons-colors.c | 15 --------------- > src/utils/bjb-icons-colors.h | 8 -------- > 3 files changed, 1 insertion(+), 26 deletions(-) > delete mode 100644 src/utils/bjb-icons-colors.c > delete mode 100644 src/utils/bjb-icons-colors.h > Nice cleanup! you shall also remove the include from bjb-main-view.c. I guess you just did not git add this one. --- a/src/bjb-main-view.c +++ b/src/bjb-main-view.c @@ -20,8 +20,6 @@ #include <libbiji/libbiji.h> #include <libgd/gd-main-view.h> -#include "utils/bjb-icons-colors.h"
Review of attachment 253331 [details] [review]: pushed as b14c71a424d70a3db0393e6eec72eabf99dd5bd1- Fix the look of the back button
Created attachment 253568 [details] [review] Remove utils/bjb-icons-colors.{c,h}
Comment on attachment 253568 [details] [review] Remove utils/bjb-icons-colors.{c,h} good
Review of attachment 253568 [details] [review]: pushed as 6f5506c739f560eda9d5012fa6f86bce0090781f - Remove utils/bjb-icons-colors.{c,h}