After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706929 - HeaderBar padding - account for double bottom button border
HeaderBar padding - account for double bottom button border
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-27 20:48 UTC by Allan Day
Modified: 2013-08-29 14:07 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10

Attachments
patch 1/2 (753 bytes, patch)
2013-08-27 20:50 UTC, Allan Day 		none Details | Review
patch 2/2 (911 bytes, patch)
2013-08-27 20:53 UTC, Allan Day 		committed Details | Review
screenshot 1 (1.16 MB, image/png)
2013-08-27 20:54 UTC, Allan Day 		  Details
screenshot 2 (896.84 KB, image/png)
2013-08-27 20:55 UTC, Allan Day 		  Details
headerbar: Remove hpadding and vpadding properties (10.24 KB, patch)
2013-08-28 10:49 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Allan Day 2013-08-27 20:48:02 UTC 
Buttons have a 2px border along their bottom edge - the second pixel appears as the lip of the toolbar, so it that the button looks like it is embedded in something solid.

Since the bottom 1px of the button looks like it is part of the HeaderBar, we should reduce the spacing below buttons by a pixel. This will ensure that padding looks even.
Comment 1 Allan Day 2013-08-27 20:50:58 UTC 
Created attachment 253309 [details] [review]
patch 1/2

We need to set the padding in CSS, not GTK+ itself.
Comment 2 Allan Day 2013-08-27 20:53:43 UTC 
Created attachment 253311 [details] [review]
patch 2/2

Add the padding to HeaderBars.
Comment 3 Allan Day 2013-08-27 20:54:27 UTC 
Created attachment 253315 [details]
screenshot 1

How it looks (focused window).
Comment 4 Allan Day 2013-08-27 20:55:05 UTC 
Created attachment 253316 [details]
screenshot 2

How it looks (unfocused window).
Comment 5 Andreas Nilsson 2013-08-27 21:07:54 UTC 
Looks good to me.
Comment 6 Jakub Steiner 2013-08-28 10:29:38 UTC 
Review of attachment 253311 [details] [review]:

The theme part looks good to me, but we'll need to rework the gtk+ patch to just remove all traces of that constant instead of zeroing it.
Comment 7 Emmanuele Bassi (:ebassi) 2013-08-28 10:49:00 UTC 
I think we should just remove the [hv]padding properties from GtkHeaderBar.
Comment 8 Emmanuele Bassi (:ebassi) 2013-08-28 10:49:57 UTC 
Created attachment 253365 [details] [review]
headerbar: Remove hpadding and vpadding properties

We really want these to be set by the theme, not programmatically.
Comment 9 Benjamin Otte (Company) 2013-08-29 10:47:04 UTC 
Comment on attachment 253365 [details] [review]
headerbar: Remove hpadding and vpadding properties

Yay! Go ahead with that.
Comment 10 Allan Day 2013-08-29 11:09:09 UTC 
Thanks Benamin!

One side effect of this is that it adds padding to the Nautilus toolbar (which is emulating HeaderBar style without actually using a HeaderBar widget). So I'd like to make sure that we have a patch for Nautilus before pushing this.
Comment 11 Allan Day 2013-08-29 12:25:57 UTC 
We have patches for nautilus in bug 706479 now. If someone can review those it should be safe to push.
Comment 12 Emmanuele Bassi (:ebassi) 2013-08-29 13:46:30 UTC 
Comment on attachment 253365 [details] [review]
headerbar: Remove hpadding and vpadding properties

Attachment 253365 [details] pushed as 889e63f - headerbar: Remove hpadding and vpadding properties