GNOME Bugzilla – Bug 706870
serial number jump bigger than 1000 warnings
Last modified: 2013-08-28 17:40:03 UTC
gtk+, wayland and weston from git master. Running gtk+ apps in weston spits lots of warnings like serial number jump bigger than 1000 (0 -> 5004) serial number jump bigger than 1000 (0 -> 5005) [...] It looks like the first serial the app receives is quite high (it seems to start at wherever the previous application left it) and gtk+ seems to assume it will start at 0, so wayland_display->serial is never updated and lots of warnings are thrown instead. This may be causing other bugs I am seeing, such as the inability to move windows.
Created attachment 253228 [details] [review] don't sasume the serial starts at zero > This may be causing other bugs I am seeing, such as the inability to move > windows. Indeed, with this patch moving windows works fine again.
Created attachment 253230 [details] [review] don't sasume the serial starts at zero > This may be causing other bugs I am seeing, such as the inability to move > windows. Indeed, with this patch moving windows works fine again.
I think the whole check is just a bit weird - the compositor doesn't sent per client serials so it would be possible for a long running client in the background to legitimately receive a new serial with a delta to the old of greater than 1000. I think we should just trust the compositor to give us a good serial number and so always assign. A warning on the delta > UINT_MAX / 2 might be useful.
Created attachment 253395 [details] [review] wayland: don't assume the serial will start at zero https://bugzilla.gnome.org/show_bug.cgi?id=706870 Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>