After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706855 - Remove custom clips and related code
Remove custom clips and related code
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-editing-services
unspecified
Other All
: Normal normal
: 1.2.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-26 23:41 UTC by Thibault Saunier
Modified: 2013-09-24 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ges: Remove custom clip (33.12 KB, patch)
2013-08-26 23:41 UTC, Thibault Saunier
none Details | Review
clip: Remove the ges_clip_fill_track method (10.43 KB, patch)
2013-08-26 23:41 UTC, Thibault Saunier
none Details | Review

Description Thibault Saunier 2013-08-26 23:41:22 UTC
This code is comming from old history of GES, and is only used in tests.
If one want a custom clip, then he should implement a subclass. Also we have some ugly code related to that
Comment 1 Thibault Saunier 2013-08-26 23:41:26 UTC
Created attachment 253207 [details] [review]
ges: Remove custom clip

If you want a custom clip then you have to subclass GESClip,
This class was pre historicall and only used for testing purposes, we
have GESTestClip for that.
Comment 2 Thibault Saunier 2013-08-26 23:41:40 UTC
Created attachment 253208 [details] [review]
clip: Remove the ges_clip_fill_track method

Its was only use by the old custom source which is dead now.

API:
    Remove ges_clip_fill_track
Comment 3 Mathieu Duponchelle 2013-08-27 15:31:23 UTC
I agree with these commits, if make check passes fine by me :)
Comment 4 Thibault Saunier 2013-08-27 22:48:26 UTC
commit ef8c4b4b6b310127fab0efb1b9d3a50dd3c2718c
Author: Thibault Saunier <thibault.saunier@collabora.com>
Date:   Mon Aug 26 19:26:08 2013 -0400

    clip: Remove the ges_clip_fill_track method
    
    Its was only use by the old custom source which is dead now.
    
    API:
        Remove ges_clip_fill_track
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706855

commit 13aeda606a2b8de15e4f3fc4a96e101fd799465d
Author: Thibault Saunier <thibault.saunier@collabora.com>
Date:   Mon Aug 26 19:15:08 2013 -0400

    ges: Remove custom clip
    
    If you want a custom clip then you have to subclass GESClip,
    This class was pre historicall and only used for testing purposes, we
    have GESTestClip for that.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706855