GNOME Bugzilla – Bug 706841
screenShield: Don't fade in the lock dialog
Last modified: 2013-08-26 22:19:12 UTC
See patch. This causes flickering for me on Intel when locking the screen.
Created attachment 253186 [details] [review] screenShield: Don't fade in the lock dialog We slide the shield over it, so the animation is rarely seen, and since no other actor is under the lock screen, the not-cleared stage can show through, causing weird issues when trying to blend.
Review of attachment 253186 [details] [review]: OK, having an animation that is rarely seen also isn't a good idea from a performance POV so kill it.
Attachment 253186 [details] pushed as b7b1260 - screenShield: Don't fade in the lock dialog
Wait a minute... This was for gdm startup (it was in the constructor), not for lock, so it was over the cleared stage and was actually very visible.
I removed both transitions: the one on startup and the one on lock. I thought the gdm login dialog one was handled by the new opacity tween in layout.js. I can add back the one in the constructor if you want.
(In reply to comment #5) > I removed both transitions: the one on startup and the one on lock. I thought > the gdm login dialog one was handled by the new opacity tween in layout.js. I > can add back the one in the constructor if you want. The "new opacity tween in layout.js"?
hm, I remember reviewing or writing a patch that faded the screenShieldGroup in the greeter animation. Guess it didn't go in.
fixed in 80ab28b