After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706756 - GtkAssistant behaviour changed and now throws 'Page flow is broken'
GtkAssistant behaviour changed and now throws 'Page flow is broken'
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.9.x
Other Linux
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-08-25 16:10 UTC by Baptiste Mille-Mathias
Modified: 2013-08-31 02:29 UTC
See Also:
GNOME target: 3.10
GNOME version: 3.9/3.10

Attachments
Video exposing the problem (248.38 KB, video/webm)
2013-08-25 16:10 UTC, Baptiste Mille-Mathias 		Details

Description Baptiste Mille-Mathias 2013-08-25 16:10:23 UTC 
Created attachment 253062 [details]
Video exposing the problem

When doing the color calibration process, You can't go further the step when you're giving a name to the color profile.

There is an error in the console.

(gnome-control-center:22014): Gtk-CRITICAL **: Page flow is broken.
You may want to end it with a page of type
GTK_ASSISTANT_PAGE_CONFIRM or GTK_ASSISTANT_PAGE_SUMMARY
Comment 1 Richard Hughes 2013-08-27 10:28:37 UTC 
Hmm, I can reproduce here with jhbuilt versions of everything. I think this is a GTK regression, as with 3.8.x it works fine with no warnings.

If you use colord from git master, you can test this without sensor hardware. Just add --create-dummy-sensor to the colord commandline. If you kill colord to restart it, be sure to restart g-s-d to get the correct devices added.

As a random possibly related note, the sidebar is no longer populated in the assistant with newer versions of GTK and the first page of the assistant is no longer marked as initially active even though it's set in the ui file. You can see both buglets in the video posted by Baptiste.
Comment 2 Richard Hughes 2013-08-27 10:52:58 UTC 
I'll reassign this to GTK+ -- but if the color panel is doing something funky I guess I'll have to use the custom page type and do all the button handling myself again, although this isn't exactly fun.
Comment 3 Matthias Clasen 2013-08-27 16:21:59 UTC 
Can't reproduce this. colord --create-dummy-device doesn't work here. Other assistant examples work fine, locally.
Comment 4 Colin Walters 2013-08-28 21:44:19 UTC 
Looks like this commit broke the a11ytests:

Is this an expected change?

diff --git a/testsuite/a11y/assistant.txt b/testsuite/a11y/assistant.txt
index ef78ff4..53bb37b 100644
--- a/testsuite/a11y/assistant.txt
+++ b/testsuite/a11y/assistant.txt
@@ -9,7 +9,7 @@ window1
   button1
     "push button"
     index: 0
-    name: Button 1
+    name: Page 1
     state: enabled focusable sensitive showing visible
     toolkit: gtk
     <AtkComponent>
@@ -24,7 +24,7 @@ window1
   button2
     "push button"
     index: 0
-    name: Button 2
+    name: Page 2
     state: enabled focusable sensitive visible
     toolkit: gtk
     <AtkComponent>


Is that an expected change?
Comment 5 Matthias Clasen 2013-08-29 04:21:27 UTC 
no, I'll have to investigate how this is happening.
Comment 6 Matthias Clasen 2013-08-31 02:29:14 UTC 
seems to be the correct output, after all