After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706700 - completion: suggestion: remove border on completion window
completion: suggestion: remove border on completion window
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-24 04:17 UTC by Christian Hergert
Modified: 2013-08-24 22:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
border comparison (20.96 KB, image/png)
2013-08-24 04:17 UTC, Christian Hergert 		  Details
completion: remove border on completion window (990 bytes, patch)
2013-08-24 04:19 UTC, Christian Hergert 		none Details | Review

Description Christian Hergert 2013-08-24 04:17:22 UTC 
Created attachment 252974 [details]
border comparison

I suggest we remove the border on the completion window.

This might be bordering on pedantic, but I remember having a debate about this years ago in monodevelop.

I'm attaching a screenshot that compares the current 1px with 0px. I find the 0px a bit sharper. A border's primary purpose is to provide context, but between window shadows and cell/column padding/alignments, i don't think it is necessary.
Comment 1 Christian Hergert 2013-08-24 04:19:00 UTC 
Created attachment 252975 [details] [review]
completion: remove border on completion window

trivial patch in case this is desired.
Comment 2 Paolo Borelli 2013-08-24 08:45:06 UTC 
I can barely spot the difference to be honest :-)

isn't border=0 the default? if yes, just remove the line.

Other than that feel free to push
Comment 3 Christian Hergert 2013-08-24 22:45:14 UTC 
Fixed in f5bd1c10b51f2c462f097496b6296a76fb6a6832.