After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706681 - userWidget: Actually respect the iconSize parameter
userWidget: Actually respect the iconSize parameter
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-23 16:50 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-08-23 20:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
userWidget: Actually respect the iconSize parameter (1.46 KB, patch)
2013-08-23 16:50 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-08-23 16:50:04 UTC 
The iconSize parameter was only being respected if it was the
default icon fallback.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-08-23 16:50:06 UTC 
Created attachment 252906 [details] [review]
userWidget: Actually respect the iconSize parameter
Comment 2 Ray Strode [halfline] 2013-08-23 17:09:42 UTC 
Review of attachment 252906 [details] [review]:

I guess this is fine since the border and such shouldn't take up any additional space outside of the icon size.

::: js/ui/userWidget.js
@@ +32,3 @@
+                                  reactive: params.reactive,
+                                  width: this._iconSize,
+                                  height: this._iconSize });

Does this make things change size in practice?  it was 48pt in the CSS file, and now it will be 64px I guess?
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-08-23 17:32:08 UTC 
Attachment 252906 [details] pushed as 1a415d5 - userWidget: Actually respect the iconSize parameter


Yes -- 64px is 48pt, so the default values match up.
Comment 4 Ray Strode [halfline] 2013-08-23 17:32:33 UTC 
Review of attachment 252906 [details] [review]:

so jasper pointed out on irc that 48pt is 64px given our assumed 96dpi