After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706672 - MonitorXrandr: skip CRTC reconfigurations that have no effect
MonitorXrandr: skip CRTC reconfigurations that have no effect
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
wayland
Depends on:
Blocks:
 
 
Reported: 2013-08-23 15:27 UTC by Giovanni Campagna
Modified: 2013-08-26 08:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MonitorXrandr: skip CRTC reconfigurations that have no effect (3.61 KB, patch)
2013-08-23 15:27 UTC, Giovanni Campagna 		reviewed Details | Review
MonitorXrandr: skip CRTC reconfigurations that have no effect (3.49 KB, patch)
2013-08-23 15:34 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-08-23 15:27:02 UTC 
If we're attempting to reconfigure the CRTCs to the same parameter,
skip the X call, as in some drivers a modeset can take time and
cause flicker.
Comment 1 Giovanni Campagna 2013-08-23 15:27:04 UTC 
Created attachment 252886 [details] [review]
MonitorXrandr: skip CRTC reconfigurations that have no effect
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-08-23 15:29:46 UTC 
Review of attachment 252886 [details] [review]:

::: src/core/monitor-xrandr.c
@@ +835,3 @@
           meta_error_trap_pop (meta_get_display ());
 
+          g_free (outputs);

Uh, are you sure this free is high enough? If we continue because nothing changed, we leak outputs. Perhaps have a goto next; with the free at the bottom of the loop?
Comment 3 Giovanni Campagna 2013-08-23 15:34:55 UTC 
Created attachment 252892 [details] [review]
MonitorXrandr: skip CRTC reconfigurations that have no effect

If we're attempting to reconfigure the CRTCs to the same parameter,
skip the X call, as in some drivers a modeset can take time and
cause flicker.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-08-23 15:49:43 UTC 
Review of attachment 252892 [details] [review]:

OK.
Comment 5 Giovanni Campagna 2013-08-26 08:08:40 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.