GNOME Bugzilla – Bug 706521
GXml check for libvala-0.18 and uses the valac without suffix instead of AM_PROG_VALAC
Last modified: 2013-08-24 07:13:45 UTC
GXml check for libvala-0.18 + valac without suffix instead of AM_PROG_VALAC which: - Fails if vala-0.18 is not present - Succeeds if vala-0.18 is present but uses the default one (be it valac 0.16 or 0.20) It would be better to check for valac using AM_PROG_VALAC([0.18]) or at least add the suffix to valac call.
I think I just fixed this in master with commit 9c0df85406233e6ac161ac51086f3e87a0963047. Let me know if that's not what you meant.
No. Right now you check if vala 0.20 is installed and replacing the above problems with vala-0.18 with vala-0.20. So gxml now: - Fails if vala-0.20 is not present - Succeeds if vala-0.20 is present but uses the default one (be it valac 0.18 or 0.22) In general you should not check for libvala if you don't use it (i.e. you don't write a tool for Vala such as valadoc). The correct approach is to use AM_PROG_VALAC instead[1] of PKG_CHECK_MODULES(VALA, libvala-0.xx >= 0.yy). You may want to look also on how build system of boxes, folks or libgee is used (they use vala.m4 IIRC). [1] https://www.gnu.org/software/automake/manual/html_node/Vala-Support.html
When I look at commit 9c0df8 that I noted above, it doesn't show it still checking 0.20. Did you look at the wrong commit/branch? https://git.gnome.org/browse/gxml/commit/?id=9c0df85406233e6ac161ac51086f3e87a0963047
(In reply to comment #3) > When I look at commit 9c0df8 that I noted above, it doesn't show it still > checking 0.20. Did you look at the wrong commit/branch? > > https://git.gnome.org/browse/gxml/commit/?id=9c0df85406233e6ac161ac51086f3e87a0963047 Yes. I'm not sure how.