After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706518 - Confusing message printed on the console at "make install"
Confusing message printed on the console at "make install"
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2013-08-21 17:11 UTC by Andrés G. Aragoneses (IRC: knocte)
Modified: 2013-09-17 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.37 KB, patch)
2013-08-21 17:12 UTC, Andrés G. Aragoneses (IRC: knocte) 		none Details | Review
Proposed patch v2 (1.37 KB, patch)
2013-08-21 17:13 UTC, Andrés G. Aragoneses (IRC: knocte) 		committed Details | Review

Description Andrés G. Aragoneses (IRC: knocte) 2013-08-21 17:11:23 UTC 
When executing "make install", this message gets printed in the console, which is confusing to a jhbuild user (especially newcomers) to say the least:

# if ~/bin/jbuild exists, it is most likely an old version, and it will
# not work; so rename it and install a symlink to the new version
# instead.

What happens is that a comment in a Makefile is being printed in the console.

I'm attaching a patch to fix this.
Comment 1 Andrés G. Aragoneses (IRC: knocte) 2013-08-21 17:12:37 UTC 
Created attachment 252629 [details] [review]
Proposed patch
Comment 2 Andrés G. Aragoneses (IRC: knocte) 2013-08-21 17:13:57 UTC 
Created attachment 252630 [details] [review]
Proposed patch v2
Comment 3 Colin Walters 2013-09-17 16:45:55 UTC 
Review of attachment 252630 [details] [review]:

It'd probably be even clearer to just move the comment out of the rule code, but this looks good to me, thanks!
Comment 4 Andrés G. Aragoneses (IRC: knocte) 2013-09-17 16:58:04 UTC 
Comment on attachment 252630 [details] [review]
Proposed patch v2

(In reply to comment #3)
> Review of attachment 252630 [details] [review]:
> 
> It'd probably be even clearer to just move the comment out of the rule code,

I would agree with that, if the rule was not as big as it is (if I place it above the rule, the comment would be too far from the lines of code that it explains).

> but this looks good to me, thanks!

Thanks, pushed: https://git.gnome.org/browse/jhbuild/commit/?id=aea1e9611aeec266d761736b159b72677d76ccc5
Comment 5 Andrés G. Aragoneses (IRC: knocte) 2013-09-17 16:58:41 UTC 
Marking bug as FIXED.